Use cbor-gen for everything except Pointers #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without touching the generated code. This is a slightly breaking change, but it shouldn't affect anyone.
We'd previously reject the pointers in UnmarshalCBOR, but cbor-gen has moved on and will now decode null. The KVs are manually decoded and should never be nil, even now, but... I'm adding the check just to be extra safe.
Stebalien
commented
Aug 2, 2024
| @@ -385,6 +383,11 @@ func loadNode( | |||
| } | |||
|
|
|||
| for _, ch := range out.Pointers { | |||
| if ch == nil { | |||
There was a problem hiding this comment.
I looked into removing the pointers and broke everything, so now I guess we're just living with this.
There was a problem hiding this comment.
yeah, that's a bit odd, I guess we're mutating in place and not saving it or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're stuck with a custom decoder for pointers, but we can at least use cbor-gen for everything else.