Update dependencies, regen and fix cbor-gen output, add dependabot #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Aug 2, 2024
|
I tried this branch out on an nv23 migration and it got the same state root as the currently released version, so there's some verification that we're not doing anything funky here. |
Raw cbor-gen output needs editing because of the handling of big.Int here
Without touching the generated code. This is a slightly breaking change, but it shouldn't affect anyone.
We'd previously reject the pointers in UnmarshalCBOR, but cbor-gen has moved on and will now decode null. The KVs are manually decoded and should never be nil, even now, but... I'm adding the check just to be extra safe.
|
@Stebalien updated this, care to take another look and we can land it? |
Stebalien
approved these changes
Oct 8, 2024
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's a little more tricky because we don't use the raw cbor-gen output but do some modifications here to deal with a custom Pointer type (pointer_cbor.go isn't included in cbor-gen generate but I manually made a minor edit) and the custom big.Int handling here. So the changes here are a unification of the new cbor-gen output and the modified one.