Skip to content

Update dependencies, regen and fix cbor-gen output, add dependabot #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 2, 2024

This one's a little more tricky because we don't use the raw cbor-gen output but do some modifications here to deal with a custom Pointer type (pointer_cbor.go isn't included in cbor-gen generate but I manually made a minor edit) and the custom big.Int handling here. So the changes here are a unification of the new cbor-gen output and the modified one.

@rvagg
Copy link
Member Author

rvagg commented Aug 5, 2024

I tried this branch out on an nv23 migration and it got the same state root as the currently released version, so there's some verification that we're not doing anything funky here.

rvagg and others added 4 commits October 8, 2024 16:12
Raw cbor-gen output needs editing because of the handling of big.Int here
Without touching the generated code. This is a slightly breaking change,
but it shouldn't affect anyone.
We'd previously reject the pointers in UnmarshalCBOR, but cbor-gen has
moved on and will now decode null. The KVs are manually decoded and
should never be nil, even now, but... I'm adding the check just to be
extra safe.
@rvagg
Copy link
Member Author

rvagg commented Oct 8, 2024

@Stebalien updated this, care to take another look and we can land it?

@Stebalien
Copy link
Member

❤️

@rvagg rvagg merged commit 83cda2f into master Oct 9, 2024
7 checks passed
@rvagg rvagg deleted the rvagg/update branch October 9, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants