Skip to content

feat: enable all verification in ci #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

feat: enable all verification in ci #390

merged 3 commits into from
Jun 23, 2025

Conversation

alaahong
Copy link
Contributor

@alaahong alaahong commented Jun 21, 2025 •
edited
Loading

As #372 mentioned, all case could be passed now, so how about to enable the forced CI verification.

  1. change default maven.test.skip to false
  2. change surefire scope for all test as /cn/idev/excel/test/**/*.java
  3. add ALL-UNNAMED into github actions ci script for higher jdk as below screenshot
image image
  1. only perform full test in test stage, and limited the scope again in post build stage

@alaahong
feat: enable all verification in ci
ee8f515 
1. change default maven.test.skip to false
2. change surefire scope for all test as /cn/idev/excel/test/**/*.java
alaahong added 2 commits June 22, 2025 09:49
@alaahong
feat: enable all verification in ci
35ce20d 
1. fix maven build issue for jdk greater than 17
@alaahong
feat: enable all verification in ci
9deff72 
1. fix maven build issue for jdk greater than 17
psxjoy
psxjoy approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Very thank your PRs.

@psxjoy psxjoy merged commit be360e7 into fast-excel:main Jun 23, 2025
4 checks passed
@psxjoy psxjoy added this to the 1.3.0 milestone Jun 23, 2025
psxjoy added a commit that referenced this pull request Jun 23, 2025
@psxjoy
Revert "feat: enable all verification in ci (#390)"
970c51f 
This reverts commit be360e7.
@psxjoy psxjoy mentioned this pull request Jun 23, 2025
Merged
psxjoy added a commit that referenced this pull request Jun 23, 2025
@psxjoy
Revert "feat: enable all verification in ci (#390)" (#392)
462cc8d 
This reverts commit be360e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psxjoy psxjoy psxjoy approved these changes

@jipengfei-jpf jipengfei-jpf Awaiting requested review from jipengfei-jpf jipengfei-jpf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alaahong @psxjoy