Skip to content

Commit be360e7

Browse files
authored
feat: enable all verification in ci (#390)
* feat: enable all verification in ci 1. change default maven.test.skip to false 2. change surefire scope for all test as /cn/idev/excel/test/**/*.java * feat: enable all verification in ci 1. fix maven build issue for jdk greater than 17 * feat: enable all verification in ci 1. fix maven build issue for jdk greater than 17
1 parent 1cfc41c commit be360e7

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ jobs:
3838
if: ${{ matrix.java != '8' }}
3939
run: ./mvnw test -B -Dmaven.test.skip=false -DargLine="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
4040
- name: Maven Build
41-
run: ./mvnw install -B -V
41+
if: ${{ matrix.java == '8' }}
42+
run: ./mvnw install -B -V -Dmaven.surefire.plugin.include.scope="/cn/idev/excel/test/core/**/*.java"
43+
- name: Maven Build
44+
if: ${{ matrix.java != '8' }}
45+
run: ./mvnw install -B -V -Dmaven.surefire.plugin.include.scope="/cn/idev/excel/test/core/**/*.java" -DargLine="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
4246
- name: Java Doc
4347
run: ./mvnw javadoc:javadoc

fastexcel-test/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
<properties>
1818
<maven.deploy.skip>true</maven.deploy.skip>
19+
<maven.surefire.plugin.include.scope>/cn/idev/excel/test/**/*.java</maven.surefire.plugin.include.scope>
1920
</properties>
2021

2122
<dependencies>
@@ -71,7 +72,7 @@
7172
<artifactId>maven-surefire-plugin</artifactId>
7273
<configuration>
7374
<includes>
74-
<include>/cn/idev/excel/test/core/**/*.java</include>
75+
<include>${maven.surefire.plugin.include.scope}</include>
7576
</includes>
7677
<testFailureIgnore>false</testFailureIgnore>
7778
</configuration>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<maven.compiler.source>1.8</maven.compiler.source>
3232
<gpg.skip>true</gpg.skip>
3333
<maven.javadoc.skip>true</maven.javadoc.skip>
34-
<maven.test.skip>true</maven.test.skip>
34+
<maven.test.skip>false</maven.test.skip>
3535
<commons-csv.version>1.11.0</commons-csv.version>
3636
<poi.version>5.4.1</poi.version>
3737
<poi-ooxml.version>5.4.1</poi-ooxml.version>

0 commit comments

Comments
 (0)