-
-
Notifications
You must be signed in to change notification settings - Fork 975
refactor: date accept number input #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Shinigami92
merged 9 commits into
faker-js:main
from
xDivisionByZerox:date-accept-number-input
Mar 25, 2022
Merged
refactor: date accept number input #670
Shinigami92
merged 9 commits into
faker-js:main
from
xDivisionByZerox:date-accept-number-input
Mar 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This history graph looks so much better :D |
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 99.34% 99.34% -0.01%
==========================================
Files 1923 1923
Lines 176863 176856 -7
Branches 904 896 -8
==========================================
- Hits 175706 175697 -9
- Misses 1101 1103 +2
Partials 56 56
|
Shinigami92
approved these changes
Mar 24, 2022
ST-DDT
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen of #576 in favor of cleaner git history.
Created in relation to #394.
I changed the way dates are created from the
Date.parse
method to theDate.constructor
since it uses that under the hood (MDN documentation).Invalid dates were not handled before.