Skip to content

refactor: date accept number input #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 25, 2022
Merged

refactor: date accept number input #670

merged 9 commits into from
Mar 25, 2022

Conversation

xDivisionByZerox
Copy link
Member

Reopen of #576 in favor of cleaner git history.

Created in relation to #394.

I changed the way dates are created from the Date.parse method to the Date.constructor since it uses that under the hood (MDN documentation).
Invalid dates were not handled before.

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner March 24, 2022 19:51
@xDivisionByZerox xDivisionByZerox changed the title Date accept number input refactor: date accept number input Mar 24, 2022
@xDivisionByZerox
Copy link
Member Author

This history graph looks so much better :D

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #670 (a041237) into main (7635dc9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      176863   176856       -7     
  Branches      904      896       -8     
==========================================
- Hits       175706   175697       -9     
- Misses       1101     1103       +2     
  Partials       56       56              
Impacted Files Coverage Δ
src/date.ts 100.00% <100.00%> (ø)
src/vendor/unique.ts 93.54% <0.00%> (-1.62%) ⬇️

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 24, 2022
@Shinigami92 Shinigami92 requested a review from a team March 24, 2022 20:55
@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Mar 24, 2022
@ST-DDT ST-DDT requested a review from a team March 24, 2022 22:37
@Shinigami92 Shinigami92 merged commit c1c6064 into faker-js:main Mar 25, 2022
@xDivisionByZerox xDivisionByZerox deleted the date-accept-number-input branch March 25, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants