Skip to content

Accept numbers as params for Date methods #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pkuczynski opened this issue Feb 1, 2022 · 4 comments
Closed

Accept numbers as params for Date methods #394

pkuczynski opened this issue Feb 1, 2022 · 4 comments
Assignees
@xDivisionByZerox
Labels
c: feature Request for new feature
Milestone
v6.1 - First bugf...

Comments

@pkuczynski
Copy link
Member

Clear and concise description of the problem

#200 (comment)

Suggested solution

Accept timestamps

Alternative

No response

Additional context

No response
@pkuczynski pkuczynski added the s: pending triage Pending Triage label Feb 1, 2022
@pkuczynski pkuczynski mentioned this issue Feb 1, 2022
Merged
@Shinigami92 Shinigami92 added c: feature Request for new feature and removed s: pending triage Pending Triage labels Feb 1, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Feb 1, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Feb 1, 2022
@xDivisionByZerox
Copy link
Member

Now this sounds like a job for me!

@xDivisionByZerox xDivisionByZerox mentioned this issue Feb 26, 2022
Closed
@ST-DDT ST-DDT linked a pull request Feb 27, 2022 that will close this issue
refactor: date accept number input #576
Closed
@pkuczynski
Copy link
Member Author

Now this sounds like a job for me!

Bear in mind there is already PR from me doing this for Date object so better of extend this one I guess otherwise it will conflict

@xDivisionByZerox
Copy link
Member

Ok, this even solves some concerns for me about accepting numbers but not plain dates. Thanks for the information

@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Mar 23, 2022
@xDivisionByZerox xDivisionByZerox mentioned this issue Mar 24, 2022
Merged
@ST-DDT
Copy link
Member

ST-DDT commented May 18, 2022

This has been fixed in #670 in v6.1.

@ST-DDT ST-DDT closed this as completed May 18, 2022
Repository owner moved this from In Progress to Done in Faker Roadmap May 18, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: feature Request for new feature
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging a pull request may close this issue.

refactor: date accept number input
4 participants
@pkuczynski @ST-DDT @Shinigami92 @xDivisionByZerox