Skip to content

chore: improve error message for faker.date.birthday #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 16, 2023
Merged

chore: improve error message for faker.date.birthday #1843

merged 5 commits into from
Feb 16, 2023

Conversation

johnmal-dev
Copy link
Contributor

@johnmal-dev johnmal-dev requested a review from a team as a code owner February 14, 2023 23:57
@ST-DDT ST-DDT linked an issue Feb 15, 2023 that may be closed by this pull request
Improve error message in birthday #1841
Closed
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: date Something is referring to the date module labels Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

Merging #1843 (c1b15c5) into next (e7230f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1843   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2346     2346           
  Lines      236469   236471    +2     
  Branches     1144     1147    +3     
=======================================
+ Hits       235597   235611   +14     
+ Misses        850      838   -12     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/date/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 93.19% <0.00%> (+3.55%) ⬆️

@ST-DDT
Copy link
Member

ST-DDT commented Feb 15, 2023

Looks like you have to run the formatter once:

pnpm run format

@xDivisionByZerox
Copy link
Member

I would categorize this as chore instead of fix. @Shinigami92 @ST-DDT other opinions?

@xDivisionByZerox xDivisionByZerox requested a review from a team February 15, 2023 14:06
@johnmal-dev johnmal-dev changed the title fix: improve error message for faker.date.birthday chore: improve error message for faker.date.birthday Feb 15, 2023
@ST-DDT ST-DDT added the c: chore PR that doesn't affect the runtime behavior label Feb 15, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team February 15, 2023 18:33
xDivisionByZerox
xDivisionByZerox approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ❤️

@ST-DDT ST-DDT merged commit a29b33e into faker-js:next Feb 16, 2023
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@johnmal-dev @matthewmayer
chore: improve error message for faker.date.birthday (faker-js#1843)
f0399a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@johnmal-dev johnmal-dev

Labels
c: chore PR that doesn't affect the runtime behavior m: date Something is referring to the date module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Improve error message in birthday
3 participants
@johnmal-dev @ST-DDT @xDivisionByZerox