chore: activate noImplicitAny (#1839)

Author: Shinigami92

src/modules/airline/index.ts

@@ -66,7 +66,9 @@ const aircraftTypeSeats: Record<AircraftType, string[]> = {
 export class AirlineModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(AirlineModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      AirlineModule.prototype
+    ) as Array<keyof AirlineModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/animal/index.ts

@@ -6,7 +6,9 @@ import type { Faker } from '../..';
 export class AnimalModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(AnimalModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      AnimalModule.prototype
+    ) as Array<keyof AnimalModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/color/index.ts

@@ -160,7 +160,9 @@ function toColorFormat(
 export class ColorModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(ColorModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      ColorModule.prototype
+    ) as Array<keyof ColorModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/commerce/index.ts

@@ -7,7 +7,9 @@ import { deprecated } from '../../internal/deprecated';
 export class CommerceModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(CommerceModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      CommerceModule.prototype
+    ) as Array<keyof CommerceModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/company/index.ts

@@ -7,7 +7,9 @@ import { deprecated } from '../../internal/deprecated';
 export class CompanyModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(CompanyModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      CompanyModule.prototype
+    ) as Array<keyof CompanyModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/database/index.ts

@@ -6,7 +6,9 @@ import type { Faker } from '../..';
 export class DatabaseModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(DatabaseModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      DatabaseModule.prototype
+    ) as Array<keyof DatabaseModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/datatype/index.ts

@@ -7,7 +7,9 @@ import { deprecated } from '../../internal/deprecated';
 export class DatatypeModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(DatatypeModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      DatatypeModule.prototype
+    ) as Array<keyof DatatypeModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/date/index.ts

@@ -28,7 +28,9 @@ function toDate(
 export class DateModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(DateModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      DateModule.prototype
+    ) as Array<keyof DateModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/finance/index.ts

@@ -8,7 +8,9 @@ import iban from './iban';
 export class FinanceModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(FinanceModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      FinanceModule.prototype
+    ) as Array<keyof FinanceModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/git/index.ts

@@ -24,7 +24,9 @@ const GIT_TIMEZONE_FORMAT = new Intl.NumberFormat('en', {
 export class GitModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(GitModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(GitModule.prototype) as Array<
+      keyof GitModule | 'constructor'
+    >) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/hacker/index.ts

@@ -6,7 +6,9 @@ import type { Faker } from '../..';
 export class HackerModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(HackerModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      HackerModule.prototype
+    ) as Array<keyof HackerModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/helpers/index.ts

@@ -10,7 +10,9 @@ import * as uniqueExec from './unique';
 export class HelpersModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(HelpersModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      HelpersModule.prototype
+    ) as Array<keyof HelpersModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }
@@ -804,8 +806,10 @@ export class HelpersModule {
 
     // Search for the requested method or definition
     for (const part of parts) {
-      currentModuleOrMethod = currentModuleOrMethod?.[part];
-      currentDefinitions = currentDefinitions?.[part];
+      currentModuleOrMethod =
+        currentModuleOrMethod?.[part as keyof typeof currentModuleOrMethod];
+      currentDefinitions =
+        currentDefinitions?.[part as keyof typeof currentDefinitions];
     }
 
     // Make method executable
@@ -903,7 +907,13 @@ export class HelpersModule {
    *
    * @since 7.5.0
    */
-  unique<Method extends (...parameters) => RecordKey>(
+  unique<
+    Method extends (
+      // TODO christopher 2023-02-14: This `any` type can be fixed by anyone if they want to.
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      ...parameters: any[]
+    ) => RecordKey
+  >(
     method: Method,
     args?: Parameters<Method>,
     options: {

src/modules/helpers/unique.ts

@@ -81,7 +81,13 @@ Try adjusting maxTime or maxRetries parameters for faker.helpers.unique().`
  * @param options.compare The function used to determine whether a value was already returned. Defaults to check the existence of the key.
  * @param options.store The store of unique entries. Defaults to `GLOBAL_UNIQUE_STORE`.
  */
-export function exec<Method extends (...parameters) => RecordKey>(
+export function exec<
+  Method extends (
+    // TODO christopher 2023-02-14: This `any` type can be fixed by anyone if they want to.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    ...parameters: any[]
+  ) => RecordKey
+>(
   method: Method,
   args: Parameters<Method>,
   options: {

src/modules/image/index.ts

@@ -26,12 +26,16 @@ export class ImageModule {
 
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(ImageModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      ImageModule.prototype
+    ) as Array<keyof ImageModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }
 
-      this[name] = this[name].bind(this);
+      this[name] =
+        // @ts-expect-error: remove this expect-error when we remove the deprecated sub-modules
+        this[name].bind(this);
     }
 
     this.unsplash = new Unsplash(this.faker);

src/modules/image/providers/placeholder.ts

@@ -9,7 +9,9 @@ import { deprecated } from '../../../internal/deprecated';
 export class Placeholder {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(Placeholder.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      Placeholder.prototype
+    ) as Array<keyof Placeholder | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/internet/index.ts

@@ -29,7 +29,9 @@ export type HTTPProtocolType = 'http' | 'https';
 export class InternetModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(InternetModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      InternetModule.prototype
+    ) as Array<keyof InternetModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/location/index.ts

@@ -7,7 +7,9 @@ import { deprecated } from '../../internal/deprecated';
 export class LocationModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(LocationModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      LocationModule.prototype
+    ) as Array<keyof LocationModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/lorem/index.ts

@@ -7,7 +7,9 @@ import { filterWordListByLength } from '../word/filterWordListByLength';
 export class LoremModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(LoremModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      LoremModule.prototype
+    ) as Array<keyof LoremModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/music/index.ts

@@ -6,7 +6,9 @@ import type { Faker } from '../..';
 export class MusicModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(MusicModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      MusicModule.prototype
+    ) as Array<keyof MusicModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/number/index.ts

@@ -8,7 +8,9 @@ import type { Mersenne } from '../../internal/mersenne/mersenne';
 export class NumberModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(NumberModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      NumberModule.prototype
+    ) as Array<keyof NumberModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/person/index.ts

@@ -61,7 +61,9 @@ function selectDefinition(
 export class PersonModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(PersonModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      PersonModule.prototype
+    ) as Array<keyof PersonModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/phone/index.ts

@@ -6,7 +6,9 @@ import type { Faker } from '../..';
 export class PhoneModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(PhoneModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      PhoneModule.prototype
+    ) as Array<keyof PhoneModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/random/index.ts

@@ -14,7 +14,9 @@ import type {
 export class RandomModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(RandomModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      RandomModule.prototype
+    ) as Array<keyof RandomModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/science/index.ts

@@ -35,7 +35,9 @@ export interface Unit {
 export class ScienceModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(ScienceModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      ScienceModule.prototype
+    ) as Array<keyof ScienceModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/string/index.ts

@@ -91,7 +91,9 @@ const SAMPLE_MAX_LENGTH = 2 ** 20;
 export class StringModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(StringModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      StringModule.prototype
+    ) as Array<keyof StringModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/system/index.ts

@@ -38,7 +38,9 @@ const CRON_DAY_OF_WEEK = [
 export class SystemModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(SystemModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      SystemModule.prototype
+    ) as Array<keyof SystemModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/vehicle/index.ts

@@ -6,7 +6,9 @@ import type { Faker } from '../..';
 export class VehicleModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(VehicleModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      VehicleModule.prototype
+    ) as Array<keyof VehicleModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/modules/word/index.ts

@@ -8,7 +8,9 @@ import { filterWordListByLength } from './filterWordListByLength';
 export class WordModule {
   constructor(private readonly faker: Faker) {
     // Bind `this` so namespaced is working correctly
-    for (const name of Object.getOwnPropertyNames(WordModule.prototype)) {
+    for (const name of Object.getOwnPropertyNames(
+      WordModule.prototype
+    ) as Array<keyof WordModule | 'constructor'>) {
       if (name === 'constructor' || typeof this[name] !== 'function') {
         continue;
       }

src/utils/types.ts

@@ -8,11 +8,16 @@ export type LiteralUnion<T extends U, U = string> =
   | (U & { zz_IGNORE_ME?: never });
 
 /**
- * Basically a function that returns a value.
+ * A function that returns a value.
  *
- * For some strange reason this is not the same as `Function`.
+ * `Function` cannot be used instead because it doesn't accept class declarations.
+ * These would fail when invoked since they are invoked without the `new` keyword.
  */
-export type Callable = (...args) => unknown;
+export type Callable = (
+  // TODO christopher 2023-02-14: This `any` type can be fixed by anyone if they want to.
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  ...args: any[]
+) => unknown;
 
 /**
  * Type that represents a single method/function name of the given type.

test/support/seededRuns.ts

@@ -201,7 +201,7 @@ class TestGenerator<
     vi_it(method, () =>
       this.callAndVerify(
         method,
-        [] as Parameters<Module[MethodName]>,
+        [] as unknown as Parameters<Module[MethodName]>,
         repetitions
       )
     );

tsconfig.json

@@ -9,6 +9,7 @@
     "allowJs": true,
     "alwaysStrict": true,
     "strictFunctionTypes": true,
+    "noImplicitAny": true,
     "useUnknownInCatchVariables": true,
     "stripInternal": true,
     "baseUrl": "."