-
-
Notifications
You must be signed in to change notification settings - Fork 974
refactor(system): replace mime db with common dataset #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(system): replace mime db with common dataset #1788
Conversation
The methods |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1788 +/- ##
==========================================
- Coverage 99.65% 99.63% -0.02%
==========================================
Files 2340 2340
Lines 242622 234301 -8321
Branches 1113 1110 -3
==========================================
- Hits 241786 233454 -8332
- Misses 815 826 +11
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO from here on we can just add stuff back again on demand
Thx for the work 👍
d37991f
Can anybody tell me why the pipeline is failing? |
Yes, this is the codecov pipeline and you remove a huge chunk of code, so the diff from prev to now differs "to much" |
Ah ok, thank you. Never saw this one failing before. That's why I was a bit lost on what to do/how to fix. |
Remove most mime-type definitions to only support common ones based on the MDN Web Docs.
A section regarding this change was documented in the "upgrade" section of the user guides.
Furthermore, remove all other properties other than
extensions
for a specific mime type since that's the only thing that is used.Unique mime types before: 2279
Unique mime types now: 72
Closes #1317.