Skip to content

Remove mime-db and use a small common set of mime-types #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ST-DDT opened this issue Aug 29, 2022 · 3 comments · Fixed by #1788
Closed

Remove mime-db and use a small common set of mime-types #1317

ST-DDT opened this issue Aug 29, 2022 · 3 comments · Fixed by #1788
Assignees
@xDivisionByZerox
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: system Something is referring to the system module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.0 - Module Re-...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Aug 29, 2022 •
edited
Loading

Clear and concise description of the problem

The mime-db is very large and most of the extensions are never used by anyone.

Also, not all mime-db entries pass the validator.js#isMimeType check.

grafik

Suggested solution

Replace mime-db with a custom/common/useful set of mime types

Alternative

Filter all mime-db entries to ensure they satisfy the validator.js#isMimeType check.

Additional context

No response
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: pending triage Pending Triage c: locale Permutes locale definitions m: system Something is referring to the system module labels Aug 29, 2022
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Aug 29, 2022
@ST-DDT ST-DDT changed the title Remove mime-db and use a small commen set of mime-types Remove mime-db and use a small common set of mime-types Aug 29, 2022
@ST-DDT ST-DDT mentioned this issue Aug 29, 2022
Merged
@ST-DDT ST-DDT added s: pending triage Pending Triage s: needs decision Needs team/maintainer decision and removed s: pending triage Pending Triage labels Oct 16, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Oct 16, 2022
@ST-DDT ST-DDT added the c: bug Something isn't working label Oct 17, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 17, 2022

I'll mark this as bug, because this causes some of our tests to fail, if we change their order.

@ST-DDT
Copy link
Member Author

ST-DDT commented Dec 15, 2022

Team decision

We will limit mime-db to 10-50 common mime types and drop all other.

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision s: pending triage Pending Triage labels Dec 15, 2022
@xDivisionByZerox xDivisionByZerox self-assigned this Jan 28, 2023
@xDivisionByZerox
Copy link
Member

I'll deal with this.

@xDivisionByZerox xDivisionByZerox mentioned this issue Jan 28, 2023
Merged
@xDivisionByZerox xDivisionByZerox linked a pull request Jan 28, 2023 that will close this issue
refactor(system): replace mime db with common dataset #1788
Merged
@Shinigami92 Shinigami92 moved this from Todo to Awaiting Review in Faker Roadmap Jan 28, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Faker Roadmap Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: bug Something isn't working c: locale Permutes locale definitions m: system Something is referring to the system module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

refactor(system): replace mime db with common dataset faker-js/faker
2 participants
@ST-DDT @xDivisionByZerox