fix: ignore build/ and DerivedData/ dirs in when reading infoPlistFiles #51833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Jun 5, 2025
|
Thanks for fixing this! 🙏 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in c783128. |
|
This pull request was successfully merged by @tjzel in c783128 When will my fix make it into a release? | How to file a pick request? |
|
@tjzel I just hit this for xcarchive files as well. Took a while to debug to find that it was a binary plist causing a |
react-native-bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
…es (#51833) Summary: #49927 introduced a regression where a Ruby script would read compilation artifacts and fail, when the user has relative build directories set in XCode. After successful compilation `build/` dir and `DerivedData/` dir have `.plist` files that aren't in UTF-8 encoding and shouldn't be read by the script. If the user tries to reinstall pods at this point, he gets the following error:  This is how you enable relative build directories in XCode.  ## Changelog: [IOS] [FIXED] - Ignore `build/` and `DerivedData/` directories when reading `.plist` files. Pull Request resolved: #51833 Test Plan: After applying this patch the problem doesn't occur anymore on my machine. Reviewed By: cortinico Differential Revision: D76030133 Pulled By: cipolleschi fbshipit-source-id: 7ae8c2d0ce28b6925245a9172154e3dcafee126f
|
This pull request was successfully merged by @tjzel in 0a9ea39 When will my fix make it into a release? | How to file a pick request? |
1 task
kligarski
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Jun 12, 2025
#2975) ## Description Bump example apps to `[email protected]` in order to fix issues with installing pods (facebook/react-native#51833). ## Changes - bump version of `react-native` and related libraries (from upgrade-helper) - bump lockfiles ## Test code and steps to reproduce I tested that both example apps build and run on Android and iOS. ## Checklist - [x] Included code example that can be used to test this change
|
I still have this issue. The Infoplist in my main project contains Chinese. [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#49927 introduced a regression where a Ruby script would read compilation artifacts and fail, when the user has relative build directories set in XCode.
After successful compilation
build/dir andDerivedData/dir have.plistfiles that aren't in UTF-8 encoding and shouldn't be read by the script. If the user tries to reinstall pods at this point, he gets the following error:This is how you enable relative build directories in XCode.
Changelog:
[IOS] [FIXED] - Ignore
build/andDerivedData/directories when reading.plistfiles.Test Plan:
After applying this patch the problem doesn't occur anymore on my machine.