Automate setting the RCTNewArchEnabled flag

[cipolleschi]

Summary:
This change automates updating App's Info.plist with the new RCTNewArchEnabled boolean entry. The value depends on how the pod install is set up. In this way, we maintain the previous UX to enable/disable the New Arch.

Context

The RCT_NEW_ARCH_ENABLE flag is a compile time flag we used for almost two years to configure the iOS apps and to determine whether the app should build with the New Arch or not.

However, given that we are looking into prebuilding React Native, we have to get rid of all the compilation flags, because they would require us to prebuild a combinatorial number of artifacts for react native. For example:

• New Arch / Hermes
• Old Arch / Hermes
• New Arch / JSC
• Old Arch / JSC
• ...

Backward compatibility

We are going to keep adding the RCT_NEW_ARCH_ENABLED flag in all the dependencies, through the cocoapods inrastructure, so libraries, which are not prebuilt, will be build for the right architecture by the app itself.

Changelog:

[iOS][Added] -

Reviewed By: cortinico

Differential Revision: D70888212

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D70888212

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D70888212

[facebook-github-bot]

This pull request has been merged in 3b3d502.

[alimek]

hey @cipolleschi

I have issues with the code after update to RN 0.80, this is probably specified to my codebase but just want to ask if this should be handled here or i need to play with this on our side.

I use one 3rd party framework, which just sits in the /ios directory which include Info.plist file and it is encoded,

the code

info_plist = Xcodeproj::Plist.read_from_path(infoPlistFile)

is just throwing error

[!] An error occurred while processing the post-install hook of the Podfile.

invalid byte sequence in UTF-8

XXX/react-native/vendor/bundle/ruby/3.4.0/gems/xcodeproj-1.25.1/lib/xcodeproj/plist.rb:91:in 'Regexp#match'
XXX/react-native/vendor/bundle/ruby/3.4.0/gems/xcodeproj-1.25.1/lib/xcodeproj/plist.rb:91:in 'String#match'
XXX/react-native/vendor/bundle/ruby/3.4.0/gems/xcodeproj-1.25.1/lib/xcodeproj/plist.rb:91:in 'Xcodeproj::Plist.file_in_conflict?'
XXX/react-native/vendor/bundle/ruby/3.4.0/gems/xcodeproj-1.25.1/lib/xcodeproj/plist.rb:20:in 'Xcodeproj::Plist.read_from_path'
XXX/react-native/node_modules/react-native/scripts/cocoapods/new_architecture.rb:182:in 'block (2 levels) in NewArchitectureHelper.set_RCTNewArchEnabled_in_info_plist'
XXX/react-native/node_modules/react-native/scripts/cocoapods/new_architecture.rb:170:in 'Array#each'
XXX/react-native/node_modules/react-native/scripts/cocoapods/new_architecture.rb:170:in 'block in NewArchitectureHelper.set_RCTNewArchEnabled_in_info_plist'
XXX/react-native/node_modules/react-native/scripts/cocoapods/new_architecture.rb:165:in 'Array#each'
XXX/react-native/node_modules/react-native/scripts/cocoapods/new_architecture.rb:165:in 'NewArchitectureHelper.set_RCTNewArchEnabled_in_info_plist'

changing code in new_architecutre.rb from:

info_plist = Xcodeproj::Plist.read_from_path(infoPlistFile)
 # Check if it contains the RCTNewArchEnabled key
 if info_plist["RCTNewArchEnabled"] and info_plist["RCTNewArchEnabled"] == new_arch_enabled
     next
 end

 # Add the key and value to the plist
 info_plist["RCTNewArchEnabled"] = new_arch_enabled ? true : false
 Xcodeproj::Plist.write_to_path(info_plist, infoPlistFile)

to:

begin
    # Read the file as a plist
    info_plist = Xcodeproj::Plist.read_from_path(infoPlistFile)
    # Check if it contains the RCTNewArchEnabled key
    if info_plist["RCTNewArchEnabled"] and info_plist["RCTNewArchEnabled"] == new_arch_enabled
        next
    end

    # Add the key and value to the plist
    info_plist["RCTNewArchEnabled"] = new_arch_enabled ? true : false
    Xcodeproj::Plist.write_to_path(info_plist, infoPlistFile)
rescue => e
    puts "Failed to read plist from #{infoPlistFile}: #{e.message}"
    next
end

but I am not sure if that's okey, please let me know and I can maybe create PR if that's okey or made some other path if you have better view ;-)