Skip to content

Updated app.listen() in Express example to use a callback function. #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated app.listen() in Express example to use a callback function. #6599

wants to merge 1 commit into from
+4 −1

Conversation

b-gonzalez
Copy link

@b-gonzalez b-gonzalez commented Jun 27, 2025 •
edited
Loading

@b-gonzalez
Updated app.listen() in the Express example to use a callback functio…
ad87375 
…n so that it is consistent with the example on the Express.js website. Closes expressjs#6594.
@b-gonzalez b-gonzalez changed the title Updated app.listen() in Express example to use a callback function." Updated app.listen() in Express example to use a callback function. Jun 27, 2025
@shivarm
Copy link
Contributor

shivarm commented Jun 27, 2025

@b-gonzalez It has already covered in #6588

@IamLizu

This comment was marked as resolved.

Sign in to view
@b-gonzalez
Copy link
Author

@b-gonzalez please update your PR description with the following to auto link the PR with the related issue.

## Notes
- Closes https://github.com/expressjs/express/issues/6594

Done.

@shivarm
Copy link
Contributor

shivarm commented Jun 28, 2025

@bjohansebas Sorry but I pointed in my above comment that this change already contain by one of My PR #6588 and also approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamOulkar ShubhamOulkar ShubhamOulkar approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can the Express example be updated to use a callback function with app.listen like on the Expressjs website?
5 participants
@b-gonzalez @shivarm @IamLizu @ShubhamOulkar @bjohansebas