-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
chore: ignore yarn.lock file and update example #6588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: ignore yarn.lock file and update example #6588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion here, since there's also devEngines and we could probably enforce using only npm.
I think devEngines will break the idea of using multiple packagemanager. But this will allow us to use any packagemanager since we are not pushing lockfile, so no conflicts. |
This PR will not break anything, it will break when we were rely on lockfiles and we know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t have a strong opinion here either – ignoring yarn.lock
to avoid lockfile conflicts when using Yarn makes sense if we want true multi–package-manager support.
We could also explore enforcing a single manager via devEngines as @bjohansebas said, but that’d be a more restrictive approach.
Given that this change is harmless for npm/pnpm users and just skips committing the Yarn lockfile, I’m happy to approve.
Yes, this will restrict the idea |
@UlisesGascon WDYT? |
When I used yarn then
yarn.lock
generated, our existing.npmrc
working fornpm and pnpm
but for yarn we have to delete it after install.This will allow us to use above package manager without conflict of lock files