When a new file fails to compile it is not watched

[ethul]

No description provided.

[forestbelton]

Hey @ethul, are you actively working on this? If not, I'd like to give it a shot. This is a pretty big pain point for me while developing PureScript applications that have a heavy JavaScript integration.

[ethul]

I would definitely appreciate a PR for this if you have a chance to work on it. Thanks!

…

On Sat, Dec 17, 2016 at 15:58 Forest Belton ***@***.***> wrote: Hey @ethul <https://github.com/ethul>, are you actively working on this? If not, I'd like to give it a shot. This is a pretty big pain point for me while developing PureScript applications that have a heavy JavaScript integration. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#74 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYyylAD3D-uAPW9Hz2j2Gdsax_kVojks5rJE0GgaJpZM4Ku_-y> .

[ethul]

@forestbelton I was just thinking that it might work to omit passing an error to the webpack callback upon failure. This may keep the file in the watch. So we would make the following a no-op:

purs-loader/src/index.js

Line 88 in 5f4d675

reject: error => callback(error),

I haven't tried this, but this is how the load works when psc-ide is used. Might be worth a try.

[ethul]

Or not a no-op, but just pass back the previous JS to the callback.

[tbenst]

Here's a possible solution: https://github.com/shama/webpack-stream/pull/126/files

[ethul]

Thanks for the tip. I was testing out something like this over the weekend. Might very well be the way to go.

[tbenst]

I did an attempt here: tbenst@b8aaa2f

But I haven't been able to test as I can't seem to get purs-loader installed via github. I imagine I'm missing a compilation step in building the package.

[ethul]

Thanks! I think something along these lines might work. I will take a look this weekend and try out some ideas.

[ethul]

I've published a beta release that should fix this issue. If anyone is willing to give it a try, that would be great! You can install the release under the beta dist tag.

npm install purs-loader@beta

In this release, there is a new option called watch. Please set this to true in your webpack config if you are running webpack in watch mode.

Thanks!

[dikmax]

In https://github.com/ethul/purs-loader/blob/topic/error-handling/src/to-javascript.js
there's a typo which prevents anything to be built.

psMoudle -> psModule.

Line 45

[ethul]

Thank you for catching this. I've fixed this in 2.4.0-beta.1.

[dikmax]

Works without any issues now. Awesome!

Thank you!!!

[ethul]

Great! Thank you for confirming

[dikmax]

Just noticed, builds stop working if a file is removed.

[ethul]

If imports to the file removed are also removed, does the build work once again?

[dikmax]

Unfortunately, I cannot reliably reproduce this issue, but it has something to do with dependencies. When I find suitable scenario I'll write it.

[tbenst]

I'm also having occasional difficulty, it works initially but occasionally stops watching after many minutes. I know that's vague and will report back if I notice a pattern

Edit: seems to stop watching when a ErrorParsingModule or UndefinedTypeVariable ocurrs. Perhaps it doesn't recompile after one is fixed if a second error of the same type (but different line) exists?

[ethul]

Thanks for following up on this. I will try out the ErrorParsingModule and UndefinedTypeVariable cases.

Thanks!

[ethul]

I released 2.4.0-beta.2 which adds a check when a module is not in the module mapping. The goal is to handle when files are removed.

I haven't been able to reproduce the watch issue yet. I tried the two errors above, but it seems to be working for me. Maybe we can track this as a new issue if we can get a reproducible case.

[ethul]

https://github.com/ethul/purs-loader/releases/tag/2.4.0