webpack doesn't always report compilation errors with --watch

[pbrant]

Steps to reproduce:

1. Run webpack with --watch
2. Break a file in two places (error is reported)
3. Fix one of the problems (error isn't reported, only clue is that webpack didn't create the final bundle)
4. Fix the other error (bundle is created)

At this point, a new error will be reported (i.e. steps 2 through 4 can be repeated indefinitely).

I've done a bit of snooping around, but I'm not sure what the appropriate fix is. The after-compile plugin callback is called and cache.errors is populated, but just adding it to compilation.errors apparently isn't enough to tell webpack to display it.

[ethul]

Thanks for the report. I will take a look. What version of purescript, purs-loader, webpack, etc., are you using?

[pbrant]

Sorry, I should have included that before:

• webpack 1.13.2
• purescript 0.9.3
• purs-loader 2.0.0-rc.1 ('next' in package.json)

along with a local clone of psa with the PureScript 0.9.x changes. I see the same behavior with plain psc though.

[ethul]

Great! Thanks for the info.

On Thursday, 18 August 2016, Peter Brant notifications@github.com wrote:

Sorry, I should have included that before:

• webpack 1.13.2
• purescript 0.9.3
• purs-loader 2.0.0-rc.1 ('next' in package.json)

along with a local clone of psa with the PureScript 0.9.x changes. I see
the same behavior with plain psc though.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#66 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVYy4K7u-iGrZb1kcWEMH43AeQ5VI6Aks5qhSHigaJpZM4Jn9-c
.

[ethul]

Resolved inadvertently in b683b0b

Should be fixed in 2.1.1. Let me know if this is still an issue.

[pbrant]

I think this might still be a problem. Here is what I tried:

Starting with a fresh clone of purescript-webpack-example:

• After installing, ran npm run webpack:watch, compilation finishes successfully
• Edited src/example/Header.purs to add a second copy of the header function named header2
• Changed DOM.text to DOM.textXX in both functions
• Rewarded with ERROR in [1/2 UnknownName] src/Example/Header.purs:12:18 and [2/2 UnknownName] src/Example/Header.purs:18:18
• Fixed one of the two functions, but nothing happened
• Fixed the second one, bundle is created

[ethul]

Thanks for confirming and for the test case. I will give it a try.

…

On Wed, Nov 23, 2016 at 19:00 Peter Brant ***@***.***> wrote: I think this might still be a problem. Here is what I tried: Starting with a fresh clone of purescript-webpack-example: - After installing, ran npm run webpack:watch, compilation finishes successfully - Edited src/example/Header.purs to add a second copy of the header function named header2 - Changed DOM.text to DOM.textXX in both functions - Rewarded with ERROR in [1/2 UnknownName] src/Example/Header.purs:12:18 and [2/2 UnknownName] src/Example/Header.purs:18:18 - Fixed one of the two functions, but nothing happened - Fixed the second one, bundle is created — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYy9DMmuqCM3NjM2gd4swMOWN1BGh5ks5rBNOagaJpZM4Jn9-c> .

[ethul]

I've published a beta release that should fix this issue. If you are willing to give it a try, that would be great! You can install the release under the beta dist tag.

npm install purs-loader@beta

In this release, there is a new option called watch. Please set this to true in your webpack config if you are running webpack in watch mode.

Thanks!

[pbrant]

Is there a particular version of webpack I should be using? For me with the beta version of purs-loader, webpack 1.14.0 and watch: true, it looks like errors aren't reported at all and the bundle isn't created after the initial run.

I've included the console output below with DEBUG=purs-loader (with a bit of additional logging added). This is a successful initial compilation, breaking Header.purs in two places (as above), and then fixing both.

Hash: 7c9b05e95ac6ed0c0772  
Version: webpack 1.14.0
Time: 4192ms
    Asset     Size  Chunks             Chunk Names
bundle.js  3.48 MB       0  [emitted]  main
   [1] ./src/Example.js 260 bytes {0} [built]
 [336] ./src/Example/Footer.js 46 bytes {0} [built]
    + 335 hidden modules

WARNING in            Src   Lib   All
Warnings   0     0     0  
Errors     0     0     0  

  purs-loader invalidating loader cache +846ms
  purs-loader invalidating loader cache +9s
 10% 0/1 build modules  purs-loader loader called Example.Header +427ms
  purs-loader spawning compiler psa [ '--output=output', 'bower_components/purescript-*/src/**/*.purs', 'src/**/*.purs' ] +0ms
  purs-loader compiling PureScript... +1ms
  purs-loader finished compiling PureScript (code = 1) +957ms
  purs-loader emitting error +0ms
  purs-loader watch is true, calling resolve(psModule) +0ms
  purs-loader loading PureScript source and FFI files from [ 'bower_components/purescript-*/src/**/*.purs', 'src/**/*.purs' ] +0ms
  purs-loader rebuilt module map +83ms
  purs-loader loading JavaScript for Example.Header +1ms
  purs-loader imports [ 'Prelude', 'React', 'React.DOM' ] +0ms
  purs-loader replaced imports [ 'Prelude', 'React', 'React.DOM' ] +0ms
  purs-loader additional imports for Example.Header: [] +1ms
  purs-loader invalidating loader cache +5s
 10% 0/1 build modules  purs-loader loader called Example.Header +428ms
  purs-loader spawning compiler psa [ '--output=output', 'bower_components/purescript-*/src/**/*.purs', 'src/**/*.purs' ] +0ms
  purs-loader compiling PureScript... +0ms
  purs-loader finished compiling PureScript (code = 0) +1s
  purs-loader loading PureScript source and FFI files from [ 'bower_components/purescript-*/src/**/*.purs', 'src/**/*.purs' ] +0ms
  purs-loader rebuilt module map +82ms
  purs-loader loading JavaScript for Example.Header +0ms
  purs-loader imports [ 'Prelude', 'React', 'React.DOM' ] +1ms
  purs-loader replaced imports [ 'Prelude', 'React', 'React.DOM' ] +0ms
  purs-loader additional imports for Example.Header: [] +0ms

[ethul]

My mistake. There was a typo which caused the bundle not to be generated. Please update to 2.4.0-beta.1 if you have a chance and give it a go.

Thanks!

[pbrant]

No joy, I'm afraid. For what it's worth, purescript-webpack-example uses bundle: false so the fix there might not have helped.

…

On Mon, Feb 20, 2017 at 7:05 PM, eric ***@***.***> wrote: My mistake. There was a typo which caused the bundle not to be generated. Please update to 2.4.0-beta.1 if you have a chance and give it a go. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABeaI5LYWAh63qO1XfFRP_Od6ojwRCMks5redYDgaJpZM4Jn9-c> .