node, sync: use new Execution API client/server #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
changed the title
refactoring to extract sample data
some refactoring
cmd: use Execution API DirectClient in silkworm main
canepat
force-pushed
the
sync_use_execution_api
branch
from
409d6bf to
c6cf804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
nodeandsyncmodules to use the client/server abstractions built around theexecutioninterface. Specifically:nodemodule facadesyncmodulenodetosyncfacade insilkwormmainExtras
This PR depends on #2004
This PR does not remove the old in-process-only implementation yet, another PR will follow