Skip to content

execution: direct client + gRPC client and server #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 15, 2024
Merged

execution: direct client + gRPC client and server #2004

merged 18 commits into from
May 15, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented May 7, 2024

This PR defines the following abstractions wrapped around the internal execution interface:

  • gRPC client and server
  • direct (i.e. in-process, gRPC-free) client implementation

This PR adds the client/server bindings for such interface, but does not yet uses them. Another PR will follow to put these bindings in play refactoring the current implementation in stagedsync package and its usage in sync module.

Extras
Some more bits have been added or touched to accommodate the needed changes:

  • convenience function concurrency::co_spawn_and_await to spawn a coroutine using co_spawn_sw and awaiting its completion asynchronously
  • new type alias TaskExecutor
  • optional stack_size parameter in rpc::Server::async_run
  • support for missing safe_block_hash in stagedsync::Fork and stagedsync::ExtendingFork

@canepat canepat requested review from JacekGlen and lupin012 May 7, 2024 19:05
@canepat canepat marked this pull request as draft May 8, 2024 10:28
canepat and others added 10 commits May 8, 2024 17:30
@canepat
some unit tests for block conversions
db53ac4 
fix H2048_from_string
improve signature of deserialize_hex_as_bytes
@canepat
some unit tests for check functions
292f2f9 
fix fork_choice_from_response
add test fixture facility
@canepat
some unit tests for getters
a9e16fc
@canepat
more unit tests for getters
3e77737 
refactoring to extract sample data
@web-flow
make fmt
0468af0
@canepat
some unit tests for inserters
2b5fe72 
some refactoring
@canepat
implement missing server-side getters
e6dcc82 
fix block number and hash in server-side GetBody RPC
unit tests for server-side checkers and getters
some cleanup
@web-flow
make fmt
e384555
@canepat
add missing bad block handling in server-side insertion
c3efdce 
add unit tests for server-side insertion
@web-flow
make fmt
786e0bb
@canepat canepat marked this pull request as ready for review May 10, 2024 15:17
@canepat canepat mentioned this pull request May 10, 2024
Merged
JacekGlen
JacekGlen approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@JacekGlen JacekGlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some minor comments. This will be fixed in subsequent PRs.
Otherwise this change should not break any functionality.

@JacekGlen JacekGlen merged commit c872f0e into master May 15, 2024
@JacekGlen JacekGlen deleted the execution_api_grpc_client_server branch May 15, 2024 09:26
@canepat canepat mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacekGlen JacekGlen JacekGlen approved these changes

@lupin012 lupin012 Awaiting requested review from lupin012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canepat @JacekGlen @web-flow