Use a distroless based runtime image #18039
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
force-pushed
the
quenting/docker/distroless
branch
from
5b9f7d9 to
7e5cbc6
Compare
sandhose
force-pushed
the
quenting/docker/speedup
branch
from
ea7a677 to
d02f0cf
Compare
sandhose
force-pushed
the
quenting/docker/distroless
branch
2 times, most recently
from
97fd25c to
82c9a2a
Compare
sandhose
force-pushed
the
quenting/docker/distroless
branch
from
82c9a2a to
47e4c6e
Compare
AndrewFerr
reviewed
Feb 21, 2025
| done | ||
|
|
||
|
|
||
| ### | ||
| ### Stage 3: runtime | ||
| ### | ||
|
|
||
| FROM docker.io/library/python:${PYTHON_VERSION}-slim-${DEBIAN_VERSION} | ||
| FROM gcr.io/distroless/base-nossl-debian${DEBIAN_VERSION_NUMERIC}:debug |
There was a problem hiding this comment.
Is there any value in making the image unprivileged?
Suggested change
| FROM gcr.io/distroless/base-nossl-debian${DEBIAN_VERSION_NUMERIC}:debug | |
| FROM gcr.io/distroless/base-nossl-debian${DEBIAN_VERSION_NUMERIC}:debug-nonroot |
There was a problem hiding this comment.
Looping back on this, root is indeed necessary since the start script may take administrative actions like changing file owners and running as other users.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #18038
Supersedes #18033