-
Notifications
You must be signed in to change notification settings - Fork 344
Speedup the building of Docker images #18038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few very minor things, but otherwise this LGTM. This included a few tricks I wasn't aware of myself. Thanks for taking the time to go through and do this!
Needs a git revert d113209
before merge, of course.
ea7a677
to
d02f0cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after temp commit revert. Thanks!
This reverts commit d02f0cf.
Analogous to element-hq/synapse#18038, switch from `pip install` to `uv pip install`, and use the build target for arch-agnostic stages. Also define build arguments for otherwise hardcoded values.
This is a split off #18033
This uses a few tricks to speed up the building of docker images:
uv pip install
instead ofpip install
. This saves a bunch of time, especially when cross-compilingapt-get download
plusdpkg --extract