Use in-call volume and mode for EC

[jmartinesp]

Content

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR
  …ccording to the bounds and shape of the user avatar and display name

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fX8dic

[bmarty]

Maybe store the previous mode and restore it here?

[jmartinesp]

From what I saw in some issues (this is poorly documented, AFAICT) the app can be 'blacklisted' if it doesn't play any audio in the 6s after enabling this mode or doesn't return to the MODE_NORMAL when it's done playing.

[bmarty]

OK, thanks.

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (48c7e46) to head (d2dbae8).
Report is 5 commits behind head on develop.

Files with missing lines	Patch %	Lines
...roid/libraries/androidutils/compat/AudioManager.kt	11.11%	14 Missing and 2 partials ⚠️
...nt/android/features/call/impl/ui/CallScreenView.kt	33.33%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4481      +/-   ##
===========================================
- Coverage    80.09%   80.07%   -0.03%     
===========================================
  Files         2081     2082       +1     
  Lines        55550    55574      +24     
  Branches      6785     6793       +8     
===========================================
+ Hits         44495    44499       +4     
- Misses        8724     8738      +14     
- Partials      2331     2337       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[toger5]

I tested it and it works. I can change the output volume while in a call with the hardware buttons (without using androids per sink volume control ui)
The output device selection in EC does not work however. It will always defaults to the loudspeaker.

I think this makes sense to become its own issue?
It will need more work on the product to design how we want to control the output devices in EC.

It will would be interesting to have an experiment if it event works?
Since we send widget actions on mute/unmute i am wondering if we can throw together a short experiment with this pr:

• muting the camera switches the android media device to the head piece
• unmuting the camera switches to the loudspeaker
  ?

[toger5]

Another issue I observed with this is, that the min volume is still very audible (there is no 0 volume option for in call audio)

Which is very nice for the user so they will never be stuck with no sound and also what a normal call does.

It is still sth we need to be aware of, since we might want to be able to silence the phone if in a conference when someone else comes by in the real world.

I think this is sth we would like to solve in EC where we provide a mute output button or similar.

[toger5]

@jmartinesp
It is okay to never be able to mute the call: element-hq/element-call#3137
So using the in-call output is the way to go.