Skip to content

Sync Strings #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

Sync Strings #1419

merged 1 commit into from
Sep 26, 2023

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner September 25, 2023 00:09
@ElementBot ElementBot requested review from julioromano and removed request for a team September 25, 2023 00:09
@ElementBot
Copy link
Collaborator Author

ElementBot commented Sep 25, 2023 •
edited
Loading

Warnings
⚠️

features/messages/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L177 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L182 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

Generated by 🚫 dangerJS against c72bb92

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rtshd3

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4964c3e) 58.06% compared to head (c72bb92) 58.06%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1419   +/-   ##
========================================
  Coverage    58.06%   58.06%           
========================================
  Files         1129     1129           
  Lines        29879    29879           
  Branches      6067     6067           
========================================
  Hits         17349    17349           
  Misses        9932     9932           
  Partials      2598     2598

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

julioromano
julioromano reviewed Sep 25, 2023
View reviewed changes
libraries/permissions/api/src/main/res/values-fr/translations.xml
<string name="dialog_permission_notification">"Pour permettre à l\'application d\'afficher les notifications, veuillez accorder l\'autorisation dans les paramètres du système."</string>
<string name="dialog_permission_camera">"Pour permettre à l’application d’utiliser l’appareil photo, veuillez accorder l’autorisation dans les paramètres du système."</string>
<string name="dialog_permission_generic">"Veuillez accorder l’autorisation dans les paramètres du système."</string>
<string name="dialog_permission_microphone">"Pour permettre à l\'application d’utiliser le microphone, veuillez accorder l’autorisation dans les paramètres du système."</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this was forgotten?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I have changed to ’ in Localazy. It can wait for the next sync (so not blocking this).

@julioromano julioromano requested a review from bmarty September 25, 2023 15:24
bmarty
bmarty approved these changes Sep 26, 2023
View reviewed changes
libraries/permissions/api/src/main/res/values-fr/translations.xml
<string name="dialog_permission_notification">"Pour permettre à l\'application d\'afficher les notifications, veuillez accorder l\'autorisation dans les paramètres du système."</string>
<string name="dialog_permission_camera">"Pour permettre à l’application d’utiliser l’appareil photo, veuillez accorder l’autorisation dans les paramètres du système."</string>
<string name="dialog_permission_generic">"Veuillez accorder l’autorisation dans les paramètres du système."</string>
<string name="dialog_permission_microphone">"Pour permettre à l\'application d’utiliser le microphone, veuillez accorder l’autorisation dans les paramètres du système."</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I have changed to ’ in Localazy. It can wait for the next sync (so not blocking this).

@bmarty bmarty merged commit d8fbf21 into develop Sep 26, 2023
@bmarty bmarty deleted the sync-localazy branch September 26, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julioromano julioromano julioromano left review comments

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElementBot @julioromano @bmarty