Skip to content

Re-enable SyncService.withEncryptionSync to improve decryption of notifications #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Re-enable SyncService.withEncryptionSync to improve decryption of notifications #1199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c850049
Re-enable `SyncService.withEncryptionSync` to improve decryption of n…
jmartinesp Aug 31, 2023
9861a28
Add feature flag
jmartinesp Aug 31, 2023
6f51921
Fix issues with sample
jmartinesp Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1198.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Re-enable `SyncService.withEncryptionSync` to improve decryption of notifications.
4 changes: 3 additions & 1 deletion .../impl/src/main/kotlin/io/element/android/libraries/matrix/impl/RustMatrixClientFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ class RustMatrixClientFactory @Inject constructor(

client.restoreSession(sessionData.toSession())

val syncService = client.syncService().finish()
val syncService = client.syncService()
.withEncryptionSync(withCrossProcessLock = false, appIdentifier = null)
.finish()

RustMatrixClient(
client = client,
Expand Down