-
Notifications
You must be signed in to change notification settings - Fork 232
Re-enable SyncService.withEncryptionSync
to improve decryption of notifications
#1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable SyncService.withEncryptionSync
to improve decryption of notifications
#1199
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1199 +/- ##
===========================================
- Coverage 57.28% 57.27% -0.01%
===========================================
Files 1044 1044
Lines 27182 27196 +14
Branches 5603 5605 +2
===========================================
+ Hits 15570 15577 +7
- Misses 9184 9190 +6
- Partials 2428 2429 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
I've just uploaded a PR that allows us to enable and disable it from developer settings (and breaks every single CI job, apparently). |
The sample project issue making the CI fail should be fixed now. |
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
It's quite self-explanatory.
Motivation and context
Closes #1198. It should help with notification decryption issues.
Tested devices
Checklist