Skip to content

Re-enable SyncService.withEncryptionSync to improve decryption of notifications #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

It's quite self-explanatory.

Motivation and context

Closes #1198. It should help with notification decryption issues.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner August 31, 2023 09:56
@jmartinesp jmartinesp requested review from julioromano and removed request for a team August 31, 2023 09:56
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1yfnLm

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (1d3d1fe) 57.28% compared to head (6f51921) 57.27%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1199      +/-   ##
===========================================
- Coverage    57.28%   57.27%   -0.01%     
===========================================
  Files         1044     1044              
  Lines        27182    27196      +14     
  Branches      5603     5605       +2     
===========================================
+ Hits         15570    15577       +7     
- Misses        9184     9190       +6     
- Partials      2428     2429       +1     
Files Changed Coverage Δ
...s/featureflag/impl/BuildtimeFeatureFlagProvider.kt 0.00% <0.00%> (ø)
...d/libraries/matrix/impl/RustMatrixClientFactory.kt 0.00% <0.00%> (ø)
...ences/impl/developer/DeveloperSettingsPresenter.kt 87.09% <75.00%> (-1.04%) ⬇️
.../android/libraries/featureflag/api/FeatureFlags.kt 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jmartinesp
Copy link
Member Author

jmartinesp commented Aug 31, 2023

I've just uploaded a PR that allows us to enable and disable it from developer settings (and breaks every single CI job, apparently).

@jmartinesp
Copy link
Member Author

The sample project issue making the CI fail should be fixed now.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@julioromano julioromano removed their request for review August 31, 2023 11:35
@jmartinesp jmartinesp merged commit 199f578 into develop Aug 31, 2023
@jmartinesp jmartinesp deleted the fix/jme/1198-enable-with-encryption-sync-again branch August 31, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable SyncService.withEncryptionSync
2 participants