Skip to content

[CI] SearchQueryThenFetchAsyncActionTests testBottomFieldSort failing #118214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Dec 7, 2024 · 4 comments
Closed

[CI] SearchQueryThenFetchAsyncActionTests testBottomFieldSort failing #118214

elasticsearchmachine opened this issue Dec 7, 2024 · 4 comments
Assignees
@original-brownbear
Labels
needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 7, 2024 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":server:test" --tests "org.elasticsearch.action.search.SearchQueryThenFetchAsyncActionTests.testBottomFieldSort" -Dtests.seed=D40E112B9C4A8F8 -Dtests.locale=pt-CH -Dtests.timezone=America/Asuncion -Druntime.java=23

Applicable branches:
8.x

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: null

Issue Reasons:

  • [8.x] 23 failures in test testBottomFieldSort (2.3% fail rate in 999 executions)
  • [8.x] 2 failures in step encryption-at-rest (9.5% fail rate in 21 executions)
  • [8.x] 5 failures in step windows-2022_checkpart1_platform-support-windows (25.0% fail rate in 20 executions)
  • [8.x] 2 failures in step ubuntu-2004-aarch64_checkpart1_platform-support-arm (9.5% fail rate in 21 executions)
  • [8.x] 5 failures in step windows-2019_checkpart1_platform-support-windows (23.8% fail rate in 21 executions)
  • [8.x] 4 failures in pipeline elasticsearch-periodic (19.0% fail rate in 21 executions)
  • [8.x] 13 failures in pipeline elasticsearch-periodic-platform-support (61.9% fail rate in 21 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Search Foundations/Search Catch all for Search Foundations >test-failure Triaged test failures from CI needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Dec 7, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@original-brownbear original-brownbear self-assigned this Dec 7, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 6 failures in test testBottomFieldSort (2.0% fail rate in 298 executions)
  • [main] 3 failures in step windows-2022_checkpart1_platform-support-windows (42.9% fail rate in 7 executions)
  • [main] 2 failures in step almalinux-8-aarch64_checkpart1_platform-support-arm (33.3% fail rate in 6 executions)
  • [main] 4 failures in pipeline elasticsearch-periodic-platform-support (57.1% fail rate in 7 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Dec 10, 2024
@elasticsearchmachine
Mute org.elasticsearch.action.search.SearchQueryThenFetchAsyncActionT…
e52d0c9 
…ests testBottomFieldSort #118214
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 8.x

Mute Reasons:

  • [8.x] 23 failures in test testBottomFieldSort (2.3% fail rate in 999 executions)
  • [8.x] 2 failures in step encryption-at-rest (9.5% fail rate in 21 executions)
  • [8.x] 5 failures in step windows-2022_checkpart1_platform-support-windows (25.0% fail rate in 20 executions)
  • [8.x] 2 failures in step ubuntu-2004-aarch64_checkpart1_platform-support-arm (9.5% fail rate in 21 executions)
  • [8.x] 5 failures in step windows-2019_checkpart1_platform-support-windows (23.8% fail rate in 21 executions)
  • [8.x] 4 failures in pipeline elasticsearch-periodic (19.0% fail rate in 21 executions)
  • [8.x] 13 failures in pipeline elasticsearch-periodic-platform-support (61.9% fail rate in 21 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Jan 21, 2025
@elasticsearchmachine
Mute org.elasticsearch.action.search.SearchQueryThenFetchAsyncActionT…
a64daf7 
…ests testBottomFieldSort #118214
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 31, 2025
@original-brownbear
Remove outdated assertion from elastic#118214
dcb8472 
Asserting that we definitely saw the "received a single result" flag
and can now deal with null responses, isn't applicable after a few
recent fixes. New requests are sent out before responses are fully
processed to keep data nodes in a tighter loop (as well as other
relaxed ordering relative to when this assertion was added) so
the flag is not guaranteed to show up as true for lower numbers
of shard requests any longer.
Lets just remove it, it was always best effort and accidental that
this worked for the numbers the test randomizes over.
@piergm piergm mentioned this issue Jan 31, 2025
Merged
original-brownbear added a commit that referenced this issue Feb 1, 2025
@original-brownbear
Remove outdated assertion from #118214 (#121435)
2b410c4 
Asserting that we definitely saw the "received a single result" flag
and can now deal with null responses, isn't applicable after a few
recent fixes. New requests are sent out before responses are fully
processed to keep data nodes in a tighter loop (as well as other
relaxed ordering relative to when this assertion was added) so
the flag is not guaranteed to show up as true for lower numbers
of shard requests any longer.
Lets just remove it, it was always best effort and accidental that
this worked for the numbers the test randomizes over.
@original-brownbear
Copy link
Member

Closed by #121435

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Feb 1, 2025
@original-brownbear
Remove outdated assertion from elastic#118214 (elastic#121435)
f3e1694 
Asserting that we definitely saw the "received a single result" flag
and can now deal with null responses, isn't applicable after a few
recent fixes. New requests are sent out before responses are fully
processed to keep data nodes in a tighter loop (as well as other
relaxed ordering relative to when this assertion was added) so
the flag is not guaranteed to show up as true for lower numbers
of shard requests any longer.
Lets just remove it, it was always best effort and accidental that
this worked for the numbers the test randomizes over.
@original-brownbear original-brownbear mentioned this issue Feb 1, 2025
Merged
elasticsearchmachine pushed a commit that referenced this issue Feb 18, 2025
@original-brownbear @drempapis
Remove outdated assertion from #118214 (#121435) (#121485)
c6368b9 
Asserting that we definitely saw the "received a single result" flag
and can now deal with null responses, isn't applicable after a few
recent fixes. New requests are sent out before responses are fully
processed to keep data nodes in a tighter loop (as well as other
relaxed ordering relative to when this assertion was added) so
the flag is not guaranteed to show up as true for lower numbers
of shard requests any longer.
Lets just remove it, it was always best effort and accidental that
this worked for the numbers the test randomizes over.

Co-authored-by: Dimitris Rempapis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@original-brownbear original-brownbear

Labels
needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@original-brownbear @elasticsearchmachine