Skip to content

Commit f3e1694

Browse files
Remove outdated assertion from elastic#118214 (elastic#121435)
Asserting that we definitely saw the "received a single result" flag and can now deal with null responses, isn't applicable after a few recent fixes. New requests are sent out before responses are fully processed to keep data nodes in a tighter loop (as well as other relaxed ordering relative to when this assertion was added) so the flag is not guaranteed to show up as true for lower numbers of shard requests any longer. Lets just remove it, it was always best effort and accidental that this worked for the numbers the test randomizes over.
1 parent a73b9a2 commit f3e1694

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

muted-tests.yml

-3
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,6 @@ tests:
143143
- class: org.elasticsearch.datastreams.DataStreamsClientYamlTestSuiteIT
144144
method: test {p0=data_stream/120_data_streams_stats/Multiple data stream}
145145
issue: https://github.com/elastic/elasticsearch/issues/118217
146-
- class: org.elasticsearch.action.search.SearchQueryThenFetchAsyncActionTests
147-
method: testBottomFieldSort
148-
issue: https://github.com/elastic/elasticsearch/issues/118214
149146
- class: org.elasticsearch.xpack.searchablesnapshots.RetrySearchIntegTests
150147
method: testSearcherId
151148
issue: https://github.com/elastic/elasticsearch/issues/118374

server/src/test/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncActionTests.java

-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ protected void run() {
220220
assertFalse(canReturnNullResponse.get());
221221
assertThat(numWithTopDocs.get(), equalTo(0));
222222
} else {
223-
assertTrue(canReturnNullResponse.get());
224223
if (withCollapse) {
225224
assertThat(numWithTopDocs.get(), equalTo(0));
226225
} else {

0 commit comments

Comments
 (0)