Skip to content

feat: dynamically update the theme #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2025
Merged

feat: dynamically update the theme #841

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbdc6bc
feat: dynamically update the theme
kingyue737 Jul 1, 2025
5482f4c
not expose setTheme
kingyue737 Jul 1, 2025
d12e163
docs: add note for `showLoading` and `hideLoading` method
kingyue737 Jul 1, 2025
d7d26c4
update docs
kingyue737 Jul 2, 2025
a88b5cb
Apply suggestions from code review
Justineo Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,12 @@ export default {
- `clear` [→](https://echarts.apache.org/en/api.html#echartsInstance.clear)
- `dispose` [→](https://echarts.apache.org/en/api.html#echartsInstance.dispose)

> [!NOTE]
> Certain ECharts instance methods aren’t exposed because their functionality is already provided by component [props](#props):
>
> - Instead of [`showLoading`](https://echarts.apache.org/en/api.html#echartsInstance.showLoading) / [`hideLoading`](https://echarts.apache.org/en/api.html#echartsInstance.hideLoading), set the `loading` and `loading-options` props;
> - Instead of `setTheme`, set the `theme` prop.

### Static Methods

Static methods can be accessed from [`echarts` itself](https://echarts.apache.org/en/api.html#echarts).
Expand Down
6 changes: 6 additions & 0 deletions README.zh-Hans.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,12 @@ export default {
- `clear` [→](https://echarts.apache.org/zh/api.html#echartsInstance.clear)
- `dispose` [→](https://echarts.apache.org/zh/api.html#echartsInstance.dispose)

> [!NOTE]
> 某些 ECharts 实例方法没有被暴露，因为它们的功能已经通过组件 [props](#props) 提供了：
>
> - 不要使用 [`showLoading`](https://echarts.apache.org/zh/api.html#echartsInstance.showLoading) / [`hideLoading`](https://echarts.apache.org/zh/api.html#echartsInstance.hideLoading)，请设置 `loading` 和 `loading-options` props；
> - 不要使用 `setTheme`，请设置 `theme` prop。

### 静态方法

静态方法请直接通过 [`echarts` 本身](https://echarts.apache.org/zh/api.html#echarts)进行调用。
Expand Down