Skip to content

feat: dynamically update the theme #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2025
Merged

feat: dynamically update the theme #841

merged 5 commits into from
Jul 2, 2025

Conversation

kingyue737
Copy link
Member

No description provided.

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-echarts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 10:30am

@Justineo
Copy link
Member

Justineo commented Jul 2, 2025

Let’s also include guidance for users to use the theme prop instead of setTheme.

@Justineo Justineo merged commit 23de318 into 8.0 Jul 2, 2025
4 checks passed
@kingyue737 kingyue737 deleted the dynamic-theme branch July 2, 2025 11:04
kingyue737 added a commit that referenced this pull request Jul 4, 2025
* chore: fix warnings and errors in demo (#839)

* chore: suppress warning in demo

* chore: prevent multiple intializations of esbuild-wasm in demo HMR

* feat: dynamically update the theme (#841)

Co-authored-by: GU Yiling <[email protected]>

* feat: add dataView slot

* vibe docs

---------

Co-authored-by: GU Yiling <[email protected]>
@kingyue737 kingyue737 mentioned this pull request Jul 24, 2025
11 tasks
Justineo added a commit that referenced this pull request Jul 25, 2025
* feat: experimental component rendered tooltip

* revert slot in VChart

* feat: use tooltip composable

* feat: try createApp

* feat: use pie chart as tooltip

* feat: switch to createVNode

The limitation is that the tooltip detached from the current component tree, not provide/inject

will try teleport next

* feat: try component with teleport

* wip

* add xAxis example

* refactor with shallowReactive

* Support dynamic slot

* fix: fill empty elements with object in array

* shallow copy option along the path

* ssr friendly

* vibe docs

* typo

* update according to the review

* add dataView slot

* chore: fix warnings and errors in demo (#839)

* chore: suppress warning in demo

* chore: prevent multiple intializations of esbuild-wasm in demo HMR

* feat: dynamically update the theme (#841)

Co-authored-by: GU Yiling <[email protected]>

* feat: add dataView slot

* vibe docs

---------

Co-authored-by: GU Yiling <[email protected]>

* fix docs typo

* update according to the review

* small fix

* remove wrapper around slotProp

* update comments

* remove anys

* add tooltip slot prop type

* target to vue 3.3

* move slot related codes to slot.ts

---------

Co-authored-by: GU Yiling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants