Skip to content

[ZEN-530] Add link protocols subject to interceptors #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oteffahi
Copy link
Contributor

@oteffahi oteffahi commented Mar 21, 2025

Link protocols can be used to identify transports that should have interceptor rules applied to them.
For example:

  • Downsampling can be configured to limit throughput to 10Hz on all transports that have a TCP connection.
  • Access Control can be configured to deny confidential messages from passing on transports with clear-text communication (i.e not TLS and QUIC).

The configuration field is named link_protocols. Possible values are all of Zenoh's currently supported link protocols: tcp, udp, tls, quic, ws, serial, unixsock-stream, unixpipe, vsock.

This change does not break compatibility with existing interceptor configurations.

Copy link

PR missing one of the required labels: {'documentation', 'dependencies', 'enhancement', 'new feature', 'breaking-change', 'bug', 'internal'}

@oteffahi oteffahi self-assigned this Mar 21, 2025
@oteffahi oteffahi added the new feature Something new is needed label Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 85.13514% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.22%. Comparing base (3ea794a) to head (90e257d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
zenoh/src/net/routing/interceptor/downsampling.rs 79.31% 6 Missing ⚠️
zenoh/src/net/routing/interceptor/mod.rs 61.53% 5 Missing ⚠️
io/zenoh-transport/src/unicast/authentication.rs 81.25% 3 Missing ⚠️
zenoh/src/net/routing/interceptor/qos_overwrite.rs 86.36% 3 Missing ⚠️
commons/zenoh-config/src/lib.rs 71.42% 2 Missing ⚠️
io/zenoh-links/zenoh-link-serial/src/unicast.rs 0.00% 1 Missing ⚠️
...enoh-links/zenoh-link-unixpipe/src/unix/unicast.rs 0.00% 1 Missing ⚠️
io/zenoh-links/zenoh-link-vsock/src/unicast.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   71.19%   71.22%   +0.02%     
==========================================
  Files         363      363              
  Lines       65947    66047     +100     
==========================================
+ Hits        46952    47043      +91     
- Misses      18995    19004       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oteffahi
Copy link
Contributor Author

Tracked in Jira as [ZEN-530]

@sashacmc sashacmc changed the title Add link protocols subject to interceptors [ZEN-530] Add link protocols subject to interceptors Mar 26, 2025
@DenisBiryukov91 DenisBiryukov91 force-pushed the interceptors/link-type branch from 8f99c64 to 0bc629a Compare March 27, 2025 09:23
@OlivierHecart OlivierHecart enabled auto-merge (squash) March 27, 2025 10:03
@OlivierHecart OlivierHecart merged commit 0e0c5d9 into eclipse-zenoh:main Mar 27, 2025
19 checks passed
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Apr 3, 2025
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Apr 4, 2025
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Apr 4, 2025
…ic (#591)

* Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc

* Apply same config changes than eclipse-zenoh/zenoh#1825

* Apply same config changes than eclipse-zenoh/zenoh#1850

* For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability
mergify bot pushed a commit to ros2/rmw_zenoh that referenced this pull request Apr 4, 2025
…ic (#591)

* Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc

* Apply same config changes than eclipse-zenoh/zenoh#1825

* Apply same config changes than eclipse-zenoh/zenoh#1850

* For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability

(cherry picked from commit a9ab960)
mergify bot pushed a commit to ros2/rmw_zenoh that referenced this pull request Apr 4, 2025
…ic (#591)

* Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc

* Apply same config changes than eclipse-zenoh/zenoh#1825

* Apply same config changes than eclipse-zenoh/zenoh#1850

* For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability

(cherry picked from commit a9ab960)
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Apr 5, 2025
…ic (#591) (#593)

* Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc

* Apply same config changes than eclipse-zenoh/zenoh#1825

* Apply same config changes than eclipse-zenoh/zenoh#1850

* For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability

(cherry picked from commit a9ab960)

Co-authored-by: Julien Enoch <[email protected]>
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Apr 5, 2025
…ic (#591) (#594)

* Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc

* Apply same config changes than eclipse-zenoh/zenoh#1825

* Apply same config changes than eclipse-zenoh/zenoh#1850

* For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability

(cherry picked from commit a9ab960)

Co-authored-by: Julien Enoch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants