Skip to content

Update TP to 4.22-I-builds/I20211010-1800 #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Oct 11, 2021

Fixes #1846

The perf improvements brought by https://bugs.eclipse.org/bugs/show_bug.cgi?id=575562 are outstanding!

Signed-off-by: Fred Bricon [email protected]

@fbricon fbricon requested a review from snjeza October 11, 2021 16:30
Copy link
Contributor

@snjeza snjeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbricon Could you apply the following patch:

diff --git a/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/SignatureHelpHandlerTest.java b/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/SignatureHelpHandlerTest.java
index bf5c7eed..669c8d41 100644
--- a/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/SignatureHelpHandlerTest.java
+++ b/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/SignatureHelpHandlerTest.java
@@ -91,7 +91,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 
 		SignatureHelp help = getSignatureHelp(cu, 4, 39);
 		assertNotNull(help);
-		assertEquals(13, help.getSignatures().size());
+		assertEquals(1, help.getSignatures().size());
 		assertEquals("foo(String s) : int", help.getSignatures().get(help.getActiveSignature()).getLabel());
 		assertTrue(help.getSignatures().get(help.getActiveSignature()).getDocumentation().getLeft().length() > 0);
 		assertEquals((Integer) 0, help.getActiveParameter());
@@ -112,7 +112,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 
 		SignatureHelp help = getSignatureHelp(cu, 5, 42);
 		assertNotNull(help);
-		assertEquals(15, help.getSignatures().size());
+		assertEquals(3, help.getSignatures().size());
 		assertEquals((Integer) 1, help.getActiveParameter());
 		assertEquals(help.getSignatures().get(help.getActiveSignature()).getLabel(), "foo(int s, String s) : int");
 	}
@@ -167,7 +167,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 		ICompilationUnit cu = pack1.createCompilationUnit("E.java", buf.toString(), false, null);
 		SignatureHelp help = getSignatureHelp(cu, 3, 12);
 		assertNotNull(help);
-		assertEquals(14, help.getSignatures().size());
+		assertEquals(2, help.getSignatures().size());
 		assertEquals(help.getSignatures().get(help.getActiveSignature()).getLabel(), "foo(String s, boolean bar) : void");
 	}
 
@@ -187,7 +187,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 		ICompilationUnit cu = pack1.createCompilationUnit("E.java", buf.toString(), false, null);
 		SignatureHelp help = getSignatureHelp(cu, 3, 12);
 		assertNotNull(help);
-		assertEquals(15, help.getSignatures().size());
+		assertEquals(3, help.getSignatures().size());
 		assertEquals(help.getSignatures().get(help.getActiveSignature()).getLabel(), "foo(String s, String b) : void");
 	}
 
@@ -325,7 +325,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 		assertTrue(help.getSignatures().get(help.getActiveSignature()).getLabel().startsWith("asList(T... "));
 		help = getSignatureHelp(cu, 5, 19);
 		assertNotNull(help);
-		assertEquals(2, help.getSignatures().size());
+		assertEquals(1, help.getSignatures().size());
 		assertTrue(help.getSignatures().get(help.getActiveSignature()).getLabel().equals("demo(String s, String... s2) : void"));
 	}
 
@@ -336,7 +336,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 		ICompilationUnit cu = type.getCompilationUnit();
 		SignatureHelp help = getSignatureHelp(cu, 4, 16);
 		assertNotNull(help);
-		assertEquals(3, help.getSignatures().size());
+		assertEquals(2, help.getSignatures().size());
 		assertTrue(help.getSignatures().get(help.getActiveSignature()).getLabel().equals("run(Class<?> clazz, String... args) : void"));
 	}
 
@@ -347,7 +347,7 @@ public class SignatureHelpHandlerTest extends AbstractCompilationUnitBasedTest {
 		ICompilationUnit cu = type.getCompilationUnit();
 		SignatureHelp help = getSignatureHelp(cu, 8, 14);
 		assertNotNull(help);
-		assertEquals(12, help.getSignatures().size());
+		assertEquals(1, help.getSignatures().size());
 		assertTrue(help.getSignatures().get(help.getActiveSignature()).getLabel().equals("test(Function<String,String> f) : void"));
 	}

Related issues:

@fbricon
Copy link
Contributor Author

fbricon commented Oct 11, 2021

fixed. build passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

completion: optimize the index engine for the scenario "complete on type name"
2 participants