Skip to content

Go to definition doesn't find results on methods inside an anonymous class #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

Go to definition doesn't find results on methods inside an anonymous class #1888

merged 1 commit into from
Sep 24, 2021

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Sep 23, 2021

@snjeza snjeza changed the title Go to definition doesn't compute/find results on methods inside an anonymous class Go to definition doesn't find results on methods inside an anonymous class Sep 23, 2021
@rgrunber
Copy link
Contributor

The change fixes these issues, but I noticed the following strange behaviour when completing an argument :

param-completion-method

Upstream also has some odd behaviour as selecting any of the completions doesn't apply them.

@snjeza
Copy link
Contributor Author

snjeza commented Sep 23, 2021 •
edited
Loading

Upstream also has some odd behaviour as selecting any of the completions doesn't apply them.

It is another issue.
I have added https://bugs.eclipse.org/bugs/show_bug.cgi?id=575149 to the commit message because the fix for it -
https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=f9169864da76ea22cff964f83c4d77c200a7c4e1 affects our SignatureHelp tests - see

Could you, please, create a separate issue for #1888 (comment)?

@rgrunber
Copy link
Contributor

Ok sounds good. I'll file it and have another look.

rgrunber
rgrunber approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issues reported upstream.

@rgrunber rgrunber merged commit f498f57 into eclipse-jdtls:master Sep 24, 2021
@rgrunber
Copy link
Contributor

@snjeza , just a heads up. Looks like https://bugs.eclipse.org/bugs/show_bug.cgi?id=575149#c26 will be reverted, so we may have to react to this if we update the I-build any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go to definition doesn't compute/find results on methods inside an anonymous class
2 participants
@snjeza @rgrunber