Go to definition doesn't compute/find results on methods inside an anonymous class

[mfussenegger]

I first thought this is a more generic regression caused by #1807 but it turns it already happened before.

Eclipse.jdt.ls version: Tested both with latest master (6f7d39a) and (3121ad9)
JDK: OpenJDK 16.0.1+9

An example:

public class App {

    public void test() {
        foo();
    }

    public String getGreeting() {
      return "foo";
    }

    public static void main(String[] args) {
        // Here go to definition on `getGreeting` works
        System.out.println(new App().getGreeting());
        Function<Integer, Integer> foo = new Function<>() {

          @Override
          public Integer apply(Integer t) {
              // Go to definition on `getGreeting` doesn't work
              new App().getGreeting();
              return 10;
          }
        };
    }
}

Also visible here:

recording.mp4

(Code in question would be available here: https://github.com/crate/crate/blob/573bd2feb9052f9a83c01bd36cfb3c7485d0e9d3/server/src/main/java/io/crate/planner/operators/InsertFromValues.java#L653-L700)

[fbricon]

I can reproduce in Eclipse 2021-06-R, so this is an upstream issue. cc @rgrunber

[rgrunber]

I have filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=574697 .

I'm able to reproduce as far back as 2018-12 (4.10) so it may have been around for a while. Also, I assume you resolved the "Function" import as the inner reference resolves correctly without it.

[rgrunber]

Looks like the change proposed by @snjeza was recently merged upstream for this. We should expect I20210806-1800 (not yet built) to contain the fix.

[pl07]

Can repro with sample project (https://github.com/crate/crate/blob/573bd2feb9052f9a83c01bd36cfb3c7485d0e9d3/server/src/main/java/io/crate/planner/operators/InsertFromValues.java#L653-L700)

Environment:
JDK16 + JLS 0.81.0 + Vscode 1.59.0

[testforstephen]

Looks like it still fails at some corner case, i reopen the issue for further look.

Here is the screenshot on the sample project https://github.com/crate/crate/blob/573bd2feb9052f9a83c01bd36cfb3c7485d0e9d3/server/src/main/java/io/crate/planner/operators/InsertFromValues.java#L663.