Skip to content

[#139] fix event concurrency issues #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 15, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #139

@elfenpiff elfenpiff requested a review from elBoberido April 15, 2024 13:42
@elfenpiff elfenpiff self-assigned this Apr 15, 2024
elBoberido
elBoberido previously approved these changes Apr 15, 2024
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The commented out code could be removed, either in this PR or a follow up PR.

elBoberido
elBoberido previously approved these changes Apr 15, 2024
elBoberido
elBoberido previously approved these changes Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 78.62%. Comparing base (d25b7df) to head (7db6a96).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   78.54%   78.62%   +0.08%     
==========================================
  Files         181      181              
  Lines       19837    19922      +85     
==========================================
+ Hits        15580    15663      +83     
- Misses       4257     4259       +2     
Files Coverage Δ
iceoryx2-bb/posix/src/unix_datagram_socket.rs 67.53% <100.00%> (+0.23%) ⬆️
iceoryx2-cal/src/event/common.rs 87.85% <100.00%> (+2.24%) ⬆️
iceoryx2-cal/src/event/mod.rs 44.44% <ø> (ø)
iceoryx2-cal/src/event/process_local.rs 87.10% <100.00%> (+0.97%) ⬆️
iceoryx2/src/port/details/publisher_connections.rs 95.94% <100.00%> (ø)
...ceoryx2/src/port/details/subscriber_connections.rs 98.43% <100.00%> (ø)
iceoryx2/src/port/listener.rs 79.54% <100.00%> (ø)
iceoryx2/src/port/publisher.rs 83.15% <100.00%> (+0.26%) ⬆️
iceoryx2/src/port/subscriber.rs 84.47% <100.00%> (ø)
iceoryx2/src/sample.rs 70.83% <ø> (ø)
... and 7 more

... and 3 files with indirect coverage changes

@elfenpiff elfenpiff requested a review from elBoberido April 15, 2024 23:43
@elfenpiff elfenpiff merged commit b0a28c6 into eclipse-iceoryx:main Apr 16, 2024
44 of 46 checks passed
@elfenpiff elfenpiff deleted the iox2-139-fix-event-concurrency-issues branch April 16, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port iceoryx1 waitset bitset to iceoryx2 to handle overflowing events
2 participants