Skip to content

Port iceoryx1 waitset bitset to iceoryx2 to handle overflowing events #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
elfenpiff opened this issue Mar 4, 2024 · 0 comments · Fixed by #148 or #186
Closed
3 tasks

Port iceoryx1 waitset bitset to iceoryx2 to handle overflowing events #139

elfenpiff opened this issue Mar 4, 2024 · 0 comments · Fixed by #148 or #186
Labels
bug Something isn't working

Comments

@elfenpiff
Copy link
Contributor

elfenpiff commented Mar 4, 2024 •
edited
Loading

Required information

Currently, the event cannot handle trigger overflows and the notifier receives connection failures when the listener goes out of scope while the notifier is triggering. Furthermore, the tests in service_event_tests.rs named concurrent*** segfault sometimes.

To address the issues:

  • All concept shall be based on the bitset from iceoryx1
  • All ignored tests from service_event_tests.rs must be unignored
  • Introduce event tests with many reconnecting listeners for many reconnecting notifiers.
@elfenpiff elfenpiff added the bug Something isn't working label Mar 4, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Add bitset
869499f
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Fix issue where memory_size uses wrong underlyi…
3ada341 
…ng type
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Remove debug println
0674bbf
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Test and document bitset
897014f
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Add release note
d7a10ee
@elfenpiff elfenpiff mentioned this issue Mar 7, 2024
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Increase rust version to 1.73 due to div_ceil
02dc883
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Increase rust version to 1.73 due to div_ceil
ad0de14
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 7, 2024
@elfenpiff
[eclipse-iceoryx#139] Increase rust version to 1.73 due to div_ceil
eb0babd
@elfenpiff elfenpiff mentioned this issue Mar 11, 2024
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 13, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust test; define BitsetElement an perform al…
6d17b9e 
…l calculation on its memory size
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 13, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust test; define BitsetElement an perform al…
c87cedd 
…l calculation on its memory size
elfenpiff added a commit that referenced this issue Mar 13, 2024
@elfenpiff
Merge pull request #148 from elfenpiff/iox2-139-port-iceoryx1-bitset-…
0a03bf7 
…waitset

[#139] introduce mpmc bitset
@elBoberido elBoberido linked a pull request Mar 13, 2024 that will close this issue
[#139] introduce mpmc bitset #148
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Add and test bitset reset_next
72dd08c
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Add and test bitset reset_next
a018d3b
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Introduce signal and id_tracker traits
f1147f9
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Remove TriggerId trait and replace it with struct
b5eab2a
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Add bitset as id tracker
373a1f3
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Provide id tracker impl
8209bfe
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] Implement semaphore as signal mechanism
0169d4a
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 19, 2024
@elfenpiff
[eclipse-iceoryx#139] IdTracker is based on a RelocatableContainer
7fbb772
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Add dynamic storage tests for dropping
851361f
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Remove calls drop of underlying type
4720d0d
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Dynamic storage test for dying initializer
78de8a8
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Prepare tests to deal with wrong type
4dda89c
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Dynamic storage config incorporates type as well
3c5fbb0
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Add tests that distinct types lead to distinct …
401301e 
…dynamic storages
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 20, 2024
@elfenpiff
[eclipse-iceoryx#139] Update release notes
b1bcfc1
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 5, 2024
@elfenpiff
[eclipse-iceoryx#139] Merge current main
140fb6e
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 5, 2024
@elfenpiff
[eclipse-iceoryx#139] Add documentation
b426ca7
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Add bitset benchmark
668321d
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust benchmark; add small optimization
93778cd
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Remove premature optimization trap active_bits …
998bfe9 
…to massively increase performance
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Refactor benchmark so that it is a event servic…
b4f3687 
…e benchmark
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Add event benchmark to readme
9db4b1e
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Fix doc examples
99d056a
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Reduce repetitions in event tests since uds hav…
021142e 
…e smaller buffer on aarch64
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Disable semaphore approach for mac os since ato…
6f7ab35 
…mic wait seems to be not compatible with shared memory and multiple memory mapping; maybe multiple addresses for the same atomic confuses someone
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Add detailed explanation and reworded doc
bd6a1de
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 8, 2024
@elfenpiff
[eclipse-iceoryx#139] Do not use sem bitset in shm for windows
9ca036a
elfenpiff added a commit that referenced this issue Apr 9, 2024
@elfenpiff
Merge pull request #167 from elfenpiff/iox2-139-events-with-bitset
50ed9d5 
[#139] events with bitset
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Fix listener connection deadlock problem
54b3eab
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Fix uds does not corrupt notifier when listener…
ae74ac3 
… goes out of scope
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Notifier can handle listener disconnect
b52c392
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Failing to send notification due to listener pr…
16a1a02 
…oblems does not cause failure on notifier side
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Using Arc instead of Rc since the factories are…
7fa6f1e 
… used concurrently
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust concurrency test parameters
0e27ca5
@elfenpiff elfenpiff mentioned this issue Apr 15, 2024
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Update changelog, remove dead code
4ffec04
elBoberido added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elBoberido
[eclipse-iceoryx#139] Do not treat the coverage upload as CI failure
7b2eff2
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust concurrency test parameters
cafee5b
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Watchdog adjustments due to test runtime
8a4e687
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Make errno in windows a thread_local global var…
b79f878 
…iable
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Fix race in global WsaInitialization
6198ddd
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust bitset test timeout
58f7b76
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Apr 15, 2024
@elfenpiff
[eclipse-iceoryx#139] Adjust test to account for specific windows beh…
7db6a96 
…avior
elfenpiff added a commit that referenced this issue Apr 16, 2024
@elfenpiff
Merge pull request #186 from elfenpiff/iox2-139-fix-event-concurrency…
b0a28c6 
…-issues

[#139] fix event concurrency issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@elfenpiff