Skip to content

iox-#27 integration tests #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2022
Merged

iox-#27 integration tests #1172

merged 5 commits into from
Feb 28, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Feb 28, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

This PR adds integration tests for client and server and fixed an issue found with the tests.

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the test A module/integration/stress/etc test for a component label Feb 28, 2022
@elBoberido elBoberido self-assigned this Feb 28, 2022
@elBoberido elBoberido changed the base branch from master to iox-#27-preparations-for-typed-client-and-server-api-tests February 28, 2022 10:24

static constexpr iox::units::Duration DEADLOCK_TIMEOUT{5_s};
Watchdog deadlockWatchdog{DEADLOCK_TIMEOUT};
ServiceDescription sd{"blue", "and", "yellow"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hypnotoad likes this.

@elBoberido elBoberido requested a review from elfenpiff February 28, 2022 10:52
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #1172 (228ea5c) into master (9a92f9a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   78.98%   78.96%   -0.03%     
==========================================
  Files         366      366              
  Lines       14589    14592       +3     
  Branches     2042     2042              
==========================================
- Hits        11523    11522       -1     
- Misses       2400     2402       +2     
- Partials      666      668       +2     
Flag Coverage Δ
unittests 78.18% <100.00%> (-0.01%) ⬇️
unittests_timing 13.93% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...clude/iceoryx_posh/internal/roudi/port_manager.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_distributor.inl 96.06% <100.00%> (+0.03%) ⬆️
iceoryx_posh/source/roudi/port_manager.cpp 84.54% <100.00%> (+0.05%) ⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp 85.71% <0.00%> (-5.72%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 63.07% <0.00%> (-0.83%) ⬇️

@mossmaurice mossmaurice changed the title Iox #27 integration tests iox-#27 integration tests Feb 28, 2022
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nitpicks.

Base automatically changed from iox-#27-preparations-for-typed-client-and-server-api-tests to master February 28, 2022 12:51
@elBoberido elBoberido force-pushed the iox-#27-integration-tests branch from b2cf26e to 228ea5c Compare February 28, 2022 12:56
@elBoberido elBoberido merged commit a8c3a76 into master Feb 28, 2022
@elBoberido elBoberido deleted the iox-#27-integration-tests branch February 28, 2022 16:25
elBoberido added a commit to ApexAI/iceoryx that referenced this pull request Mar 31, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A module/integration/stress/etc test for a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants