-
Notifications
You must be signed in to change notification settings - Fork 421
iox-#27 integration tests #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
static constexpr iox::units::Duration DEADLOCK_TIMEOUT{5_s}; | ||
Watchdog deadlockWatchdog{DEADLOCK_TIMEOUT}; | ||
ServiceDescription sd{"blue", "and", "yellow"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think hypnotoad likes this.
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 78.98% 78.96% -0.03%
==========================================
Files 366 366
Lines 14589 14592 +3
Branches 2042 2042
==========================================
- Hits 11523 11522 -1
- Misses 2400 2402 +2
- Partials 666 668 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few nitpicks.
b2cf26e
to
228ea5c
Compare
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)This PR adds integration tests for client and server and fixed an issue found with the tests.
Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References