[22592] Fix windows example tests in Debug and mitigate rtps example flakiness (backport #5744)
#5755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
11 tasks
Mario-DL
approved these changes
May 12, 2025
…iness (#5744) * Refs #22592: Fix windows Debug example tests Signed-off-by: Mario-DL <[email protected]> * Refs #22592: Initialize samples_received_ in rtps example ReaderApp Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: fix rtps example: Include a mechanism to ensure that the first sample is acked by all the matched readers and to prevent the next sample to piss it Signed-off-by: Mario Dominguez <[email protected]> * TODO: REMOVE THIS COMMIT. (Dis)Enable workflows for windows testing Signed-off-by: Mario Dominguez <[email protected]> * Revert "TODO: REMOVE THIS COMMIT. (Dis)Enable workflows for windows testing" This reverts commit 7c4b08c. Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: Apply Miguels rev Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: Decrease HB period for hello_world publisher Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario-DL <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit a7f2258)
Mario-DL
force-pushed
the
mergify/bp/3.1.x/pr-5744
branch
from
35443ec to
77ee38a
Compare
Mario-DL
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
rtpsexample by adding a mechanism to the writers to ensure that the first sample is acked by all the matched readers (which, in other words mean to ensure that the readers have already matched us) to prevent the next sample to piss it.@Mergifyio backport 3.1.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5744 done by [Mergify](https://mergify.com).