-
Notifications
You must be signed in to change notification settings - Fork 816
[22592] Fix windows example tests in Debug
and mitigate rtps
example flakiness
#5744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mario-DL <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
… first sample is acked by all the matched readers and to prevent the next sample to piss it Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…esting" This reverts commit 7c4b08c. Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL |
Signed-off-by: Mario Dominguez <[email protected]>
@cferreiragonz, yes, I could reproduce the failure in local. |
That managed to fix the failing tests in Ubuntu. |
@Mergifyio backport 3.1.x |
✅ Backports have been created
|
…iness (#5744) * Refs #22592: Fix windows Debug example tests Signed-off-by: Mario-DL <[email protected]> * Refs #22592: Initialize samples_received_ in rtps example ReaderApp Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: fix rtps example: Include a mechanism to ensure that the first sample is acked by all the matched readers and to prevent the next sample to piss it Signed-off-by: Mario Dominguez <[email protected]> * TODO: REMOVE THIS COMMIT. (Dis)Enable workflows for windows testing Signed-off-by: Mario Dominguez <[email protected]> * Revert "TODO: REMOVE THIS COMMIT. (Dis)Enable workflows for windows testing" This reverts commit 7c4b08c. Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: Apply Miguels rev Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: Decrease HB period for hello_world publisher Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario-DL <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit a7f2258)
…iness (#5744) * Refs #22592: Fix windows Debug example tests Signed-off-by: Mario-DL <[email protected]> * Refs #22592: Initialize samples_received_ in rtps example ReaderApp Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: fix rtps example: Include a mechanism to ensure that the first sample is acked by all the matched readers and to prevent the next sample to piss it Signed-off-by: Mario Dominguez <[email protected]> * TODO: REMOVE THIS COMMIT. (Dis)Enable workflows for windows testing Signed-off-by: Mario Dominguez <[email protected]> * Revert "TODO: REMOVE THIS COMMIT. (Dis)Enable workflows for windows testing" This reverts commit 7c4b08c. Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: Apply Miguels rev Signed-off-by: Mario Dominguez <[email protected]> * Refs #22592: Decrease HB period for hello_world publisher Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario-DL <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit a7f2258)
Description
This PR:
rtps
example by adding a mechanism to the writers to ensure that the first sample is acked by all the matched readers (which, in other words mean to ensure that the readers have already matched us) to prevent the next sample to piss it.@Mergifyio backport 3.1.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist