Skip to content

[22974] Improve SHM configuration on large data transports #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2025
Merged

[22974] Improve SHM configuration on large data transports #5725

merged 5 commits into from
Mar 21, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 20, 2025 •
edited
Loading

Description

This improves the segment size and port queue capacity configuration on LARGE_DATA and EASY_MODE.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • NA: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima March 20, 2025 17:58
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 20, 2025
@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Mar 20, 2025
@MiguelCompany MiguelCompany force-pushed the feature/shm-default-segment-size branch from 18d4570 to 286f7bb Compare March 21, 2025 09:35
@MiguelCompany MiguelCompany changed the title Increase SHM default segment size [22974] Increase SHM default segment size Mar 21, 2025
@MiguelCompany MiguelCompany changed the title [22974] Increase SHM default segment size [22974] Improve SHM configuration on large data transports Mar 21, 2025
MiguelCompany added a commit that referenced this pull request Mar 21, 2025
@MiguelCompany
Improve SHM configuration on large data transports (#5725)
c5ad7a3 
Squashed commit of the following:

commit 286f7bb
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:35:25 2025 +0100

    Refs #22974. Setup port_queue_capacity.

    Signed-off-by: Miguel Company <[email protected]>

commit 8cc2092
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:30:15 2025 +0100

    Refs #22974. Add constexpr `SharedMemTransportDescriptor::shm_implicit_segment_size`

    Signed-off-by: Miguel Company <[email protected]>

commit caffd9f
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:21:59 2025 +0100

    Refs #22974. Increase segment size on large data / easy mode.

    Signed-off-by: Miguel Company <[email protected]>

commit a3aea07
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:14:17 2025 +0100

    Refs #22974. Only override buffer sizes when they are 0.

    Signed-off-by: Miguel Company <[email protected]>

commit a020c1d
Author: juanjo4936 <[email protected]>
Date:   Fri Mar 21 06:55:28 2025 +0100

    Add modules support to idl_serialize (#5691)

    * Refs 22893: First implementation of module resolution for IDLs

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Corrected some errors in IDL

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Corrected typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Complete IDL module resolution

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Corrected some issues

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Expanded funtionality to accept all types

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Uncrustufy

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Solved failing CI

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: added test to test the new feature

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Refatored the test for the new feature

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Uncrustify

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected small typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected extensibility issue

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: applied most of reviewer suggestions

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: added explicit appendable extensibility (like the rest)

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: uncrustify

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: refatoring of tabulation function

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: last suggestions

    Signed-off-by: Juan Lopez Fernandez <[email protected]>

    ---------

    Signed-off-by: Juanjo Garcia <[email protected]>
    Signed-off-by: Juan Lopez Fernandez <[email protected]>
    Co-authored-by: Juan Lopez Fernandez <[email protected]>

commit 3fcf91b
Author: Mario Domínguez López <[email protected]>
Date:   Thu Mar 20 16:38:50 2025 +0100

    Update types with Fast DDS Gen v4.0.4 (#5720)

    Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany added a commit that referenced this pull request Mar 21, 2025
@MiguelCompany
Improve SHM configuration on large data transports (#5725)
f8ba45b 
Squashed commit of the following:

commit 286f7bb
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:35:25 2025 +0100

    Refs #22974. Setup port_queue_capacity.

    Signed-off-by: Miguel Company <[email protected]>

commit 8cc2092
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:30:15 2025 +0100

    Refs #22974. Add constexpr `SharedMemTransportDescriptor::shm_implicit_segment_size`

    Signed-off-by: Miguel Company <[email protected]>

commit caffd9f
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:21:59 2025 +0100

    Refs #22974. Increase segment size on large data / easy mode.

    Signed-off-by: Miguel Company <[email protected]>

commit a3aea07
Author: Miguel Company <[email protected]>
Date:   Fri Mar 21 10:14:17 2025 +0100

    Refs #22974. Only override buffer sizes when they are 0.

    Signed-off-by: Miguel Company <[email protected]>

commit a020c1d
Author: juanjo4936 <[email protected]>
Date:   Fri Mar 21 06:55:28 2025 +0100

    Add modules support to idl_serialize (#5691)

    * Refs 22893: First implementation of module resolution for IDLs

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Corrected some errors in IDL

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Corrected typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Complete IDL module resolution

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Corrected some issues

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Expanded funtionality to accept all types

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Uncrustufy

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Solved failing CI

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: added test to test the new feature

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Refatored the test for the new feature

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: Uncrustify

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected small typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected extensibility issue

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: applied most of reviewer suggestions

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: added explicit appendable extensibility (like the rest)

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: uncrustify

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: refatoring of tabulation function

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: corrected typo

    Signed-off-by: Juanjo Garcia <[email protected]>

    * Refs 22893: last suggestions

    Signed-off-by: Juan Lopez Fernandez <[email protected]>

    ---------

    Signed-off-by: Juanjo Garcia <[email protected]>
    Signed-off-by: Juan Lopez Fernandez <[email protected]>
    Co-authored-by: Juan Lopez Fernandez <[email protected]>

commit 3fcf91b
Author: Mario Domínguez López <[email protected]>
Date:   Thu Mar 20 16:38:50 2025 +0100

    Update types with Fast DDS Gen v4.0.4 (#5720)

    Signed-off-by: Mario Dominguez <[email protected]>
@MiguelCompany MiguelCompany requested review from cferreiragonz and removed request for cferreiragonz March 21, 2025 11:03
cferreiragonz
cferreiragonz approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 430609d into master Mar 21, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the feature/shm-default-segment-size branch March 21, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @cferreiragonz