[22893] Add modules support to idl_serialize #5691

juanjo4936 · 2025-03-06T15:06:22Z

In this PR we implement the capabilities to resolve the module structure in IDL types, so they are written in a nested structure. A new function is introduced to resolve the structure, and the final writing of the IDL is modified to accommodate the new structure.

@Mergifyio backport 3.1.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Juanjo Garcia <[email protected]>

juanlofer-eprosima

Could you please update the versions.md file?

src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.hpp

src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp

Signed-off-by: Juanjo Garcia <[email protected]>

Signed-off-by: Juan Lopez Fernandez <[email protected]>

juanlofer-eprosima

LGTM

Squashed commit of the following: commit c13bdad Author: Juan Lopez Fernandez <[email protected]> Date: Thu Mar 20 12:08:57 2025 +0100 Refs 22893: last suggestions Signed-off-by: Juan Lopez Fernandez <[email protected]> commit a82d132 Author: Juanjo Garcia <[email protected]> Date: Thu Mar 20 09:07:54 2025 +0100 Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> commit a9b6ffe Author: Juanjo Garcia <[email protected]> Date: Thu Mar 20 09:02:54 2025 +0100 Refs 22893: refatoring of tabulation function Signed-off-by: Juanjo Garcia <[email protected]> commit c6ee6bb Author: Juanjo Garcia <[email protected]> Date: Tue Mar 18 15:38:46 2025 +0100 Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> commit be5a35a Author: Juanjo Garcia <[email protected]> Date: Tue Mar 18 15:36:32 2025 +0100 Refs 22893: uncrustify Signed-off-by: Juanjo Garcia <[email protected]> commit 12092ad Author: Juanjo Garcia <[email protected]> Date: Tue Mar 18 15:29:24 2025 +0100 Refs 22893: added explicit appendable extensibility (like the rest) Signed-off-by: Juanjo Garcia <[email protected]> commit 6e03bbc Author: Juanjo Garcia <[email protected]> Date: Tue Mar 18 14:36:08 2025 +0100 Refs 22893: applied most of reviewer suggestions Signed-off-by: Juanjo Garcia <[email protected]> commit d5cd099 Author: Juanjo Garcia <[email protected]> Date: Thu Mar 13 12:59:34 2025 +0100 Refs 22893: corrected extensibility issue Signed-off-by: Juanjo Garcia <[email protected]> commit e2cd5d0 Author: Juanjo Garcia <[email protected]> Date: Mon Mar 10 14:47:18 2025 +0100 Refs 22893: corrected small typo Signed-off-by: Juanjo Garcia <[email protected]> commit 3dd472a Author: Juanjo Garcia <[email protected]> Date: Mon Mar 10 14:41:12 2025 +0100 Refs 22893: Uncrustify Signed-off-by: Juanjo Garcia <[email protected]> commit f84d74e Author: Juanjo Garcia <[email protected]> Date: Mon Mar 10 14:37:56 2025 +0100 Refs 22893: Refatored the test for the new feature Signed-off-by: Juanjo Garcia <[email protected]> commit 9b74502 Author: Juanjo Garcia <[email protected]> Date: Mon Mar 10 10:49:29 2025 +0100 Refs 22893: added test to test the new feature Signed-off-by: Juanjo Garcia <[email protected]> commit c8ce3ec Author: Juanjo Garcia <[email protected]> Date: Mon Mar 10 09:36:38 2025 +0100 Refs 22893: Solved failing CI Signed-off-by: Juanjo Garcia <[email protected]> commit e4737ff Author: Juanjo Garcia <[email protected]> Date: Fri Mar 7 14:04:01 2025 +0100 Refs 22893: Uncrustufy Signed-off-by: Juanjo Garcia <[email protected]> commit 111f050 Author: Juanjo Garcia <[email protected]> Date: Fri Mar 7 13:55:03 2025 +0100 Refs 22893: Expanded funtionality to accept all types Signed-off-by: Juanjo Garcia <[email protected]> commit c68b8d7 Author: Juanjo Garcia <[email protected]> Date: Thu Mar 6 16:47:54 2025 +0100 Refs 22893: Corrected some issues Signed-off-by: Juanjo Garcia <[email protected]> commit e5ef077 Author: Juanjo Garcia <[email protected]> Date: Thu Mar 6 16:24:51 2025 +0100 Refs 22893: Complete IDL module resolution Signed-off-by: Juanjo Garcia <[email protected]> commit 5e2bbc3 Author: Juanjo Garcia <[email protected]> Date: Thu Mar 6 16:16:11 2025 +0100 Refs 22893: Corrected typo Signed-off-by: Juanjo Garcia <[email protected]> commit af01efe Author: Juanjo Garcia <[email protected]> Date: Thu Mar 6 16:12:00 2025 +0100 Refs 22893: Corrected some errors in IDL Signed-off-by: Juanjo Garcia <[email protected]> commit 7f681b3 Author: Juanjo Garcia <[email protected]> Date: Thu Mar 6 16:01:15 2025 +0100 Refs 22893: First implementation of module resolution for IDLs Signed-off-by: Juanjo Garcia <[email protected]>

juanlofer-eprosima · 2025-03-21T07:31:01Z

https://github.com/Mergifyio backport 3.1.x

mergify · 2025-03-21T07:31:05Z

backport 3.1.x

✅ Backports have been created

#5728 [22893] Add modules support to idl_serialize (backport #5691) has been created for branch 3.1.x

* Refs 22893: First implementation of module resolution for IDLs Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected some errors in IDL Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Complete IDL module resolution Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected some issues Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Expanded funtionality to accept all types Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Uncrustufy Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Solved failing CI Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: added test to test the new feature Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Refatored the test for the new feature Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Uncrustify Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected small typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected extensibility issue Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: applied most of reviewer suggestions Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: added explicit appendable extensibility (like the rest) Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: uncrustify Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: refatoring of tabulation function Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: last suggestions Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juanjo Garcia <[email protected]> Signed-off-by: Juan Lopez Fernandez <[email protected]> Co-authored-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit a020c1d)

Squashed commit of the following: commit 286f7bb Author: Miguel Company <[email protected]> Date: Fri Mar 21 10:35:25 2025 +0100 Refs #22974. Setup port_queue_capacity. Signed-off-by: Miguel Company <[email protected]> commit 8cc2092 Author: Miguel Company <[email protected]> Date: Fri Mar 21 10:30:15 2025 +0100 Refs #22974. Add constexpr `SharedMemTransportDescriptor::shm_implicit_segment_size` Signed-off-by: Miguel Company <[email protected]> commit caffd9f Author: Miguel Company <[email protected]> Date: Fri Mar 21 10:21:59 2025 +0100 Refs #22974. Increase segment size on large data / easy mode. Signed-off-by: Miguel Company <[email protected]> commit a3aea07 Author: Miguel Company <[email protected]> Date: Fri Mar 21 10:14:17 2025 +0100 Refs #22974. Only override buffer sizes when they are 0. Signed-off-by: Miguel Company <[email protected]> commit a020c1d Author: juanjo4936 <[email protected]> Date: Fri Mar 21 06:55:28 2025 +0100 Add modules support to idl_serialize (#5691) * Refs 22893: First implementation of module resolution for IDLs Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected some errors in IDL Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Complete IDL module resolution Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected some issues Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Expanded funtionality to accept all types Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Uncrustufy Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Solved failing CI Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: added test to test the new feature Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Refatored the test for the new feature Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Uncrustify Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected small typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected extensibility issue Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: applied most of reviewer suggestions Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: added explicit appendable extensibility (like the rest) Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: uncrustify Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: refatoring of tabulation function Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: last suggestions Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juanjo Garcia <[email protected]> Signed-off-by: Juan Lopez Fernandez <[email protected]> Co-authored-by: Juan Lopez Fernandez <[email protected]> commit 3fcf91b Author: Mario Domínguez López <[email protected]> Date: Thu Mar 20 16:38:50 2025 +0100 Update types with Fast DDS Gen v4.0.4 (#5720) Signed-off-by: Mario Dominguez <[email protected]>

* Refs 22893: First implementation of module resolution for IDLs Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected some errors in IDL Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Complete IDL module resolution Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Corrected some issues Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Expanded funtionality to accept all types Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Uncrustufy Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Solved failing CI Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: added test to test the new feature Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Refatored the test for the new feature Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: Uncrustify Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected small typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected extensibility issue Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: applied most of reviewer suggestions Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: added explicit appendable extensibility (like the rest) Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: uncrustify Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: refatoring of tabulation function Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> * Refs 22893: last suggestions Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juanjo Garcia <[email protected]> Signed-off-by: Juan Lopez Fernandez <[email protected]> Co-authored-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit a020c1d) Co-authored-by: juanjo4936 <[email protected]>

Refs 22893: First implementation of module resolution for IDLs

7f681b3

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested a review from richiprosima March 6, 2025 15:06

github-actions bot added the ci-pending PR which CI is running label Mar 6, 2025

Juanjo Garcia added 3 commits March 6, 2025 16:12

Refs 22893: Corrected some errors in IDL

af01efe

Signed-off-by: Juanjo Garcia <[email protected]>

Refs 22893: Corrected typo

5e2bbc3

Signed-off-by: Juanjo Garcia <[email protected]>

Refs 22893: Complete IDL module resolution

e5ef077

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 force-pushed the add/idl_modules branch from cce84f0 to e5ef077 Compare March 6, 2025 15:47

Juanjo Garcia added 2 commits March 6, 2025 16:47

Refs 22893: Corrected some issues

c68b8d7

Signed-off-by: Juanjo Garcia <[email protected]>

Refs 22893: Expanded funtionality to accept all types

111f050

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 marked this pull request as ready for review March 7, 2025 12:55

juanjo4936 requested review from richiprosima and removed request for richiprosima March 7, 2025 12:55

Refs 22893: Uncrustufy

e4737ff

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested review from richiprosima and removed request for richiprosima March 7, 2025 13:04

juanjo4936 added this to the v3.2.0 milestone Mar 7, 2025

juanjo4936 requested review from richiprosima and removed request for richiprosima March 7, 2025 13:06

juanjo4936 modified the milestone: v3.2.0 Mar 7, 2025

juanjo4936 requested review from richiprosima and removed request for richiprosima March 7, 2025 13:07

Refs 22893: Solved failing CI

c8ce3ec

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested review from richiprosima and removed request for richiprosima March 10, 2025 08:37

Refs 22893: added test to test the new feature

9b74502

Signed-off-by: Juanjo Garcia <[email protected]>

Refs 22893: added explicit appendable extensibility (like the rest)

12092ad

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested review from richiprosima and removed request for richiprosima March 18, 2025 14:30

Juanjo Garcia added 2 commits March 18, 2025 15:36

Refs 22893: uncrustify

be5a35a

Signed-off-by: Juanjo Garcia <[email protected]>

Refs 22893: corrected typo

c6ee6bb

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested review from richiprosima and removed request for richiprosima March 18, 2025 14:41

juanlofer-eprosima changed the title ~~[22893] Implementation of modules for IDLs~~ [22893] Add modules support to idl_serialize Mar 19, 2025

juanlofer-eprosima requested changes Mar 19, 2025

View reviewed changes

Refs 22893: refatoring of tabulation function

a9b6ffe

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested review from richiprosima and removed request for richiprosima March 20, 2025 08:03

Refs 22893: corrected typo

a82d132

Signed-off-by: Juanjo Garcia <[email protected]>

juanjo4936 requested review from richiprosima and removed request for richiprosima March 20, 2025 08:08

Refs 22893: last suggestions

c13bdad

Signed-off-by: Juan Lopez Fernandez <[email protected]>

juanlofer-eprosima approved these changes Mar 20, 2025

View reviewed changes

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima March 20, 2025 11:09

MiguelCompany merged commit a020c1d into master Mar 21, 2025
14 of 17 checks passed

MiguelCompany deleted the add/idl_modules branch March 21, 2025 05:55

mergify bot mentioned this pull request Mar 21, 2025

[22893] Add modules support to idl_serialize (backport #5691) #5728

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22893] Add modules support to idl_serialize #5691

[22893] Add modules support to idl_serialize #5691

juanjo4936 commented Mar 6, 2025 •

edited by juanlofer-eprosima

Loading

juanlofer-eprosima left a comment

juanlofer-eprosima left a comment

juanlofer-eprosima commented Mar 21, 2025

mergify bot commented Mar 21, 2025 •

edited

Loading

[22893] Add modules support to idl_serialize #5691

[22893] Add modules support to idl_serialize #5691

Conversation

juanjo4936 commented Mar 6, 2025 • edited by juanlofer-eprosima Loading

Contributor Checklist

Reviewer Checklist

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

juanlofer-eprosima commented Mar 21, 2025

mergify bot commented Mar 21, 2025 • edited Loading

✅ Backports have been created

juanjo4936 commented Mar 6, 2025 •

edited by juanlofer-eprosima

Loading

mergify bot commented Mar 21, 2025 •

edited

Loading