Skip to content

[22937] Fix several_writers_on_unack_sample_removed flaky test (backport #5716) #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 19, 2025

Description

As a consequence of #5540, the expectations in discovery phase of the test had to be adjusted.
Thanks @juanlofer-eprosima for giving the hint of that PR.

@Mergifyio backport 3.1.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5716 done by [Mergify](https://mergify.com).

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)
@MiguelCompany MiguelCompany added this to the v2.14.5 milestone Mar 19, 2025
@MiguelCompany MiguelCompany self-requested a review March 19, 2025 20:38
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 19, 2025
@EugenioCollado EugenioCollado merged commit a4ce090 into 2.14.x Mar 20, 2025
18 checks passed
@EugenioCollado EugenioCollado deleted the mergify/bp/2.14.x/pr-5716 branch March 20, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants