Skip to content

[22937] Fix several_writers_on_unack_sample_removed flaky test #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

[22937] Fix several_writers_on_unack_sample_removed flaky test #5716

merged 1 commit into from
Mar 19, 2025

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Mar 19, 2025 •
edited by MiguelCompany
Loading

Description

As a consequence of #5540, the expectations in discovery phase of the test had to be adjusted.
Thanks @juanlofer-eprosima for giving the hint of that PR.

@Mergifyio backport 3.1.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Mar 19, 2025
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima March 19, 2025 14:56
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 19, 2025
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima March 19, 2025 14:57
MiguelCompany
MiguelCompany approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 19, 2025 •
edited
Loading

backport 3.1.x 2.14.x 2.10.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit fb68bae into master Mar 19, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/22937 branch March 19, 2025 20:31
mergify bot pushed a commit that referenced this pull request Mar 19, 2025
@Mario-DL @mergify
Fix several_writers_on_unack_sample_removed flaky test (#5716)
1fea080 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)
mergify bot pushed a commit that referenced this pull request Mar 19, 2025
@Mario-DL @mergify
Fix several_writers_on_unack_sample_removed flaky test (#5716)
7cca78e 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)
This was referenced Mar 19, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 19, 2025
@Mario-DL @mergify
Fix several_writers_on_unack_sample_removed flaky test (#5716)
c79665a 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)
@mergify mergify bot mentioned this pull request Mar 19, 2025
Merged
11 tasks
MiguelCompany pushed a commit that referenced this pull request Mar 20, 2025
@mergify @Mario-DL
Fix several_writers_on_unack_sample_removed flaky test (#5716) (#5717)
cf0f43b 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)

Co-authored-by: Mario Domínguez López <[email protected]>
EugenioCollado pushed a commit that referenced this pull request Mar 20, 2025
@mergify @Mario-DL
Fix several_writers_on_unack_sample_removed flaky test (#5716) (#5718)
a4ce090 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)

Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Apr 2, 2025
@mergify @Mario-DL
Fix several_writers_on_unack_sample_removed flaky test (#5716) (#5719)
274b356 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb68bae)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany