Skip to content

[22873] Setup ROS 2 Easy Mode at participant creation #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 31, 2025

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Mar 12, 2025

Description

This PR adds support for manually configuring ROS 2 Easy Mode using easy_mode_ip in RTPSParticipantAttributes. If the Easy Mode IP is manually configured, the value of the ROS2_EASY_MODE environment variable is ignored.

This PR depends on

and must be merged after that one.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Related documentation PR: [22873] Setup ROS 2 Easy Mode at participant creation Fast-DDS-docs#1045
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 12, 2025
@Carlosespicur Carlosespicur changed the base branch from master to feature/easy-mode-ip March 12, 2025 10:28
Base automatically changed from feature/easy-mode-ip to master March 18, 2025 14:46
@Carlosespicur Carlosespicur force-pushed the feature/easy-mode-setup branch from d075c58 to 6dd9e6a Compare March 20, 2025 06:51
@rsanchez15 rsanchez15 added this to the v3.2.1 milestone Mar 20, 2025
@Carlosespicur Carlosespicur force-pushed the feature/easy-mode-setup branch from 905a22c to d28f87c Compare March 21, 2025 09:37
@Carlosespicur Carlosespicur requested review from juanlofer-eprosima and removed request for juanlofer-eprosima March 25, 2025 13:48
Signed-off-by: Carlosespicur <[email protected]>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before merging we should consider if this should have a backport to 3.2.0, as there might be ABI break in createParticipant.

@juanlofer-eprosima juanlofer-eprosima merged commit 70d2b16 into master Mar 31, 2025
16 of 17 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/easy-mode-setup branch March 31, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants