-
Notifications
You must be signed in to change notification settings - Fork 816
[22873] Setup ROS 2 Easy Mode at participant creation #5701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
16 tasks
d075c58
to
6dd9e6a
Compare
juanlofer-eprosima
requested changes
Mar 20, 2025
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
905a22c
to
d28f87c
Compare
juanlofer-eprosima
requested changes
Mar 21, 2025
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
juanlofer-eprosima
requested changes
Mar 26, 2025
Signed-off-by: Carlosespicur <[email protected]>
juanlofer-eprosima
requested changes
Mar 27, 2025
Signed-off-by: Carlosespicur <[email protected]>
443df2e
to
eac37c7
Compare
juanlofer-eprosima
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but before merging we should consider if this should have a backport to 3.2.0, as there might be ABI break in createParticipant
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for manually configuring ROS 2 Easy Mode using easy_mode_ip in RTPSParticipantAttributes. If the Easy Mode IP is manually configured, the value of the ROS2_EASY_MODE environment variable is ignored.
This PR depends on
and must be merged after that one.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist