-
Notifications
You must be signed in to change notification settings - Fork 816
[22872] Configure ROS 2 Easy Mode via C++ and XML #5689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
4fa7db0
to
754d56e
Compare
Signed-off-by: Carlosespicur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions from a quick review:
- I would add a call to
IPLocator::isIPv4
in each setter to ensure that a valid IPv4 is used. We might also add this check in the current environment variable parsing for consistency. - A test to check that non-IPv4 IPs are not accepted would be great.
- Also, we need to modify the
fastdds_profiles.xsd
to add the new XML tag
Signed-off-by: Carlosespicur <[email protected]>
1199fbc
to
ca957a7
Compare
…mpty ip Signed-off-by: Carlosespicur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We must decide now if we want to extend the new API to allow for shared memory configuration (only option that would affect this PR), reuse the builtin transports configuration (which allows to configure some of SHM parameters but indirectly), extend it to also include SHM specific params, or create a new dedicated attribute/qos.
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds a new member in RTPSParticipant attributes to store the IP of the Discovery Server when using ROS 2 Easy Mode.
easy_mode
setter.easy_mode_ip
tag.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist