Skip to content

[22849] Builtin flow controller #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2025

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Mar 4, 2025

Description

This PR introduces the feature of setting a flow controller for the builtin rtps data writers of PDP and EDP.

This PR is on top of the refactor done in #5679

The feature has been documented in this PR

Todo:

  • Tests for WLP
  • Test for TypeLookup
  • Tests for general discovery
  • Test participant destruction Data P [ud]
  • Test low bytes per second
  • Test flow controller name not included in flow controllers list
  • PR documenting new feature

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado force-pushed the 22849/feature/builtin_flow_controller branch from b2c4893 to 3861c8a Compare March 4, 2025 15:05
@EugenioCollado EugenioCollado marked this pull request as ready for review March 6, 2025 15:51
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 6, 2025
@EugenioCollado EugenioCollado force-pushed the 22849/feature/builtin_flow_controller branch from 072f13b to 058bc6e Compare March 7, 2025 09:02
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 7, 2025
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima March 7, 2025 09:07
@EugenioCollado EugenioCollado changed the title Builtin flow controller [22849] Builtin flow controller Mar 7, 2025
@EugenioCollado EugenioCollado added this to the v3.2.0 milestone Mar 7, 2025
@EugenioCollado EugenioCollado force-pushed the 22849/feature/builtin_flow_controller branch from 058bc6e to de224a3 Compare March 13, 2025 15:06
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 13, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 13, 2025 15:55
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 13, 2025
@EugenioCollado EugenioCollado force-pushed the 22849/feature/builtin_flow_controller branch from de224a3 to 9bd04b3 Compare March 14, 2025 07:28
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 14, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 14, 2025 07:28
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 14, 2025
@EugenioCollado EugenioCollado force-pushed the 22849/feature/builtin_flow_controller branch from fec6fc9 to d0c72db Compare March 18, 2025 15:53
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 18, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 18, 2025 15:54
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 18, 2025
richiware
richiware previously approved these changes Mar 19, 2025
Signed-off-by: Eugenio Collado <[email protected]>

Refactor builtin readers

Signed-off-by: Eugenio Collado <[email protected]>

Uncrustify

Signed-off-by: Eugenio Collado <[email protected]>

Refactor WLP

Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
Signed-off-by: Eugenio Collado <[email protected]>
@MiguelCompany MiguelCompany merged commit df6db3d into master Mar 19, 2025
15 of 17 checks passed
@MiguelCompany MiguelCompany deleted the 22849/feature/builtin_flow_controller branch March 19, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants