Skip to content

[21433] Improve PDPClients initialization #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2024
Merged

[21433] Improve PDPClients initialization #5459

merged 3 commits into from
Dec 18, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Dec 4, 2024 •
edited by MiguelCompany
Loading

Description

This PR avoids setting multicast metatraffic locators for PDPClients.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Dec 4, 2024
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima December 4, 2024 14:48
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 4, 2024
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label Dec 5, 2024
@cferreiragonz cferreiragonz force-pushed the bugfix/improve_clients_init branch from 4654d27 to 3f56028 Compare December 10, 2024 09:14
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima December 11, 2024 07:11
@cferreiragonz cferreiragonz marked this pull request as ready for review December 11, 2024 15:54
@cferreiragonz cferreiragonz removed the ci-pending PR which CI is running label Dec 11, 2024
@MiguelCompany MiguelCompany self-requested a review December 13, 2024 10:06
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 13, 2024
@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Dec 13, 2024
@cferreiragonz
Copy link
Contributor Author

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Dec 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 451847c into master Dec 18, 2024
30 of 31 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/improve_clients_init branch December 18, 2024 07:43
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@cferreiragonz @mergify
Improve PDPClients initialization (#5459)
9920d6a 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)
@mergify mergify bot mentioned this pull request Dec 18, 2024
Merged
11 tasks
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@cferreiragonz @mergify
Improve PDPClients initialization (#5459)
f826362 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@cferreiragonz @mergify
Improve PDPClients initialization (#5459)
00511b9 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)
This was referenced Dec 18, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@cferreiragonz @mergify
Improve PDPClients initialization (#5459)
649fb3b 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)
@mergify mergify bot mentioned this pull request Dec 18, 2024
Merged
11 tasks
EugenioCollado pushed a commit that referenced this pull request Dec 27, 2024
@cferreiragonz @EugenioCollado
Improve PDPClients initialization (#5459)
4a3f7ba 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Jan 17, 2025
@mergify @cferreiragonz
Improve PDPClients initialization (#5459) (#5505)
64212a7 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)

Co-authored-by: Carlos Ferreira González <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Jan 20, 2025
@cferreiragonz @MiguelCompany
Improve PDPClients initialization (#5459)
cd2d53c 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)
MiguelCompany added a commit that referenced this pull request Jan 21, 2025
@mergify @cferreiragonz @MiguelCompany
Improve PDPClients initialization (#5459) (#5508)
1dfdae9 
* Improve PDPClients initialization (#5459)

* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 451847c)

* Fix backport namespaces

Signed-off-by: Miguel Company <[email protected]>

* Fix build

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Carlos Ferreira González <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
cferreiragonz added a commit that referenced this pull request Mar 6, 2025
@cferreiragonz
Improve PDPClients initialization (#5459)
ac5b16a 
* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany added a commit that referenced this pull request Mar 7, 2025
@mergify @cferreiragonz @MiguelCompany
Improve PDPClients initialization (#5459) (#5507)
a5d913f 
* Improve PDPClients initialization (#5459)

* Refs #21433: Add Test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS

Signed-off-by: cferreiragonz <[email protected]>

* Refs #21433: Typo

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>

* Fix backport namespaces

Signed-off-by: Miguel Company <[email protected]>

* Fix build

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Carlos Ferreira González <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @MiguelCompany