[21397] Parse IDL file on `DynamicTypeBuilderFactory::create_type_w_uri` #4943

YangboLong · 2024-06-13T03:06:39Z

Description

This PR implements DynamicTypeBuilderFactory::create_type_w_uri. It will parse an IDL file, and return the corresponding DynamicTypeBuilder.

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
N/A: Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp

examples/cpp/dds/IdlParserExample/IdlParser_main.cpp

include/fastdds/dds/xtypes/dynamic_types/DynamicTypeBuilderFactory.hpp

src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp

richiware · 2024-09-02T06:50:44Z

Review current state. Next should be the testing.

test/feature/idl_parser/CMakeLists.txt

Signed-off-by: Yangbo Long <[email protected]>

Handle the case when array size being an identifier instead of integer. For example: const long size_1 = 5; struct ArraySingleDimensionLiteralsShort { short var_array_short[size_1]; }; Signed-off-by: Yangbo Long <[email protected]>

Signed-off-by: Yangbo Long <[email protected]>

Signed-off-by: Miguel Company <[email protected]>

Signed-off-by: Yangbo Long <[email protected]>

YangboLong force-pushed the idl-parser branch from e059b51 to 147a65c Compare June 15, 2024 21:21

EduPonz added this to the v3.0.0 milestone Jun 21, 2024

YangboLong force-pushed the idl-parser branch from 147a65c to 305c953 Compare June 24, 2024 03:04

elianalf added needs-review PR that is ready to be reviewed to-do labels Jun 24, 2024

YangboLong force-pushed the idl-parser branch from 305c953 to f7c4531 Compare June 30, 2024 16:46

EduPonz modified the milestones: v3.0.0, v3.0.1 Jul 19, 2024

juanlofer-eprosima changed the title ~~Parse IDL string for xtypes~~ [21397] Parse IDL string for xtypes Jul 22, 2024

juanlofer-eprosima modified the milestones: v3.0.1, v3.0.0 Jul 22, 2024

richiware requested changes Jul 26, 2024

View reviewed changes

YangboLong force-pushed the idl-parser branch from 00e89d3 to aebff0d Compare August 10, 2024 02:59

rsanchez15 modified the milestones: v3.0.1, v3.1.0 Sep 4, 2024

YangboLong force-pushed the idl-parser branch from 204b6ba to 31fd100 Compare September 6, 2024 03:05

YangboLong force-pushed the idl-parser branch from e4dd01a to 7365c33 Compare September 28, 2024 01:59

rsanchez15 modified the milestones: v3.1.0, v3.2.0 Oct 3, 2024

YangboLong requested a review from richiware October 13, 2024 02:36

YangboLong force-pushed the idl-parser branch from d3c3347 to 0c5855a Compare October 15, 2024 03:01

YangboLong force-pushed the idl-parser branch from 86eb83e to d26114a Compare November 4, 2024 01:52

rsanchez15 mentioned this pull request Nov 25, 2024

[21924] Roadmap update #5412

Merged

4 tasks

MiguelCompany self-requested a review November 29, 2024 12:02

MiguelCompany reviewed Dec 4, 2024

View reviewed changes

test/feature/idl_parser/CMakeLists.txt Outdated Show resolved Hide resolved

YangboLong force-pushed the idl-parser branch from 0f36299 to f5e72a8 Compare December 5, 2024 04:29

YangboLong requested a review from MiguelCompany December 6, 2024 04:13

YangboLong and others added 19 commits January 8, 2025 20:35

Test alases.idl

4b4c219

Signed-off-by: Yangbo Long <[email protected]>

Try fixing ci/cd

36e4b77

Signed-off-by: Yangbo Long <[email protected]>

Fix struct parsing with member being array

19f06de

Handle the case when array size being an identifier instead of integer. For example: const long size_1 = 5; struct ArraySingleDimensionLiteralsShort { short var_array_short[size_1]; }; Signed-off-by: Yangbo Long <[email protected]>

Allow positive_int_const to be const_expr

371976e

Signed-off-by: Yangbo Long <[email protected]>

Parse arrays.idl (in progress)

acb0497

Signed-off-by: Yangbo Long <[email protected]>

Handle scoped names in arithmetic expressions

237e27d

Signed-off-by: Yangbo Long <[email protected]>

Finish arrays.idl testing

d7eeaab

Signed-off-by: Yangbo Long <[email protected]>

Test relative_path_include.idl

6617989

Signed-off-by: Yangbo Long <[email protected]>

Start to test unions.idl

3cec731

Signed-off-by: Yangbo Long <[email protected]>

Fix union case label parsing

64189c7

Signed-off-by: Yangbo Long <[email protected]>

Finish unions.idl testing

cf3fcee

Signed-off-by: Yangbo Long <[email protected]>

Fix internal error spews

d9a1abb

Signed-off-by: Yangbo Long <[email protected]>

Try fixing ci/cd errors

3c16ba5

Signed-off-by: Yangbo Long <[email protected]>

Address PR comments

64d50f4

Signed-off-by: Yangbo Long <[email protected]>

Escape separator in CMake path variable

4e9793f

Signed-off-by: Miguel Company <[email protected]>

Add API to set preprocessor path.

fe2b456

Signed-off-by: Miguel Company <[email protected]>

Split preprocessor and flags.

3722f66

Signed-off-by: Miguel Company <[email protected]>

Pass preprocessor to IDL parser.

09035d8

Signed-off-by: Miguel Company <[email protected]>

Set preprocessor on tests

d8229c5

Signed-off-by: Miguel Company <[email protected]>

YangboLong dismissed stale reviews from MiguelCompany and richiware via ffd8571 January 9, 2025 02:43

Move idl parser implementation to create_type_w_uri

de5b3d3

Signed-off-by: Yangbo Long <[email protected]>

YangboLong force-pushed the idl-parser branch from ffd8571 to de5b3d3 Compare January 9, 2025 02:45

YangboLong requested a review from MiguelCompany January 9, 2025 02:48

MiguelCompany approved these changes Jan 9, 2025

View reviewed changes

MiguelCompany changed the title ~~[21397] Parse IDL string for xtypes~~ [21397] Parse IDL file on DynamicTypeBuilderFactory::create_type_w_uri Jan 9, 2025

MiguelCompany merged commit 25a694c into eProsima:master Jan 9, 2025
17 checks passed

This was referenced Jan 10, 2025

[20523] Improve IDL parser tests #5559

Merged

[20523] Improve IDL parser tests #5567

Merged

EugenioCollado mentioned this pull request Mar 17, 2025

XTYPES IDL parsing feature eProsima/Fast-DDS-docs#1046

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21397] Parse IDL file on `DynamicTypeBuilderFactory::create_type_w_uri` #4943

[21397] Parse IDL file on `DynamicTypeBuilderFactory::create_type_w_uri` #4943

YangboLong commented Jun 13, 2024 •

edited by MiguelCompany

Loading

richiware commented Sep 2, 2024

[21397] Parse IDL file on DynamicTypeBuilderFactory::create_type_w_uri #4943

[21397] Parse IDL file on DynamicTypeBuilderFactory::create_type_w_uri #4943

Conversation

YangboLong commented Jun 13, 2024 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

richiware commented Sep 2, 2024

[21397] Parse IDL file on `DynamicTypeBuilderFactory::create_type_w_uri` #4943

[21397] Parse IDL file on `DynamicTypeBuilderFactory::create_type_w_uri` #4943

YangboLong commented Jun 13, 2024 •

edited by MiguelCompany

Loading