Skip to content

[15315] Fix null dereference on eprosima::fastrtps::xmlparser::XMLParser::parseXMLBitsetDynamicType #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

MiguelCompany
Copy link
Member

Description

Fixes oss-fuzz issue 47122

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany changed the title Fix null dereference on eprosima::fastrtps::xmlparser::XMLParser::parseXMLBitsetDynamicType [14456] Fix null dereference on eprosima::fastrtps::xmlparser::XMLParser::parseXMLBitsetDynamicType Jul 29, 2022
@MiguelCompany MiguelCompany changed the title [14456] Fix null dereference on eprosima::fastrtps::xmlparser::XMLParser::parseXMLBitsetDynamicType [15315] Fix null dereference on eprosima::fastrtps::xmlparser::XMLParser::parseXMLBitsetDynamicType Jul 29, 2022
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit be4529d into master Jul 29, 2022
@MiguelCompany MiguelCompany deleted the bugfix/14456 branch July 29, 2022 09:06
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.7.x 2.6.x

mergify bot pushed a commit that referenced this pull request Oct 20, 2022
* Refs #14456. Regression test added.

Signed-off-by: Miguel Company <[email protected]>

* Refs #14456. Fix issue.

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit be4529d)
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2022

mergify bot pushed a commit that referenced this pull request Oct 20, 2022
* Refs #14456. Regression test added.

Signed-off-by: Miguel Company <[email protected]>

* Refs #14456. Fix issue.

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit be4529d)
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.3.x

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2022

backport 2.3.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 21, 2022
* Refs #14456. Regression test added.

Signed-off-by: Miguel Company <[email protected]>

* Refs #14456. Fix issue.

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit be4529d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants