Fix null dereference on parseXMLBitsetDynamicType (#2893)

* Refs #14456. Regression test added.

Signed-off-by: Miguel Company <[email protected]>

* Refs #14456. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

Author: MiguelCompany

src/cpp/rtps/xmlparser/XMLDynamicParser.cpp

@@ -394,6 +394,11 @@ XMLP_ret XMLParser::parseXMLBitsetDynamicType(
     uint32_t mId = 0;
 
     const char* name = p_root->Attribute(NAME);
+    if (nullptr == name)
+    {
+        logError(XMLPARSER, "Error parsing 'bitsetDcl' type. No name attribute given.");
+        return XMLP_ret::XML_ERROR;
+    }
 
     const char* baseType = p_root->Attribute(BASE_TYPE);
     if (baseType != nullptr)

test/unittest/xmlparser/XMLParserTests.cpp

@@ -58,6 +58,7 @@ TEST_F(XMLParserTests, regressions)
     EXPECT_EQ(XMLP_ret::XML_ERROR, XMLParser::loadXML("regressions/13418.xml", root));
     EXPECT_EQ(XMLP_ret::XML_ERROR, XMLParser::loadXML("regressions/13454.xml", root));
     EXPECT_EQ(XMLP_ret::XML_ERROR, XMLParser::loadXML("regressions/13513.xml", root));
+    EXPECT_EQ(XMLP_ret::XML_ERROR, XMLParser::loadXML("regressions/14456.xml", root));
 }
 
 TEST_F(XMLParserTests, NoFile)

test/unittest/xmlparser/regressions/14456.xml

@@ -0,0 +1 @@
+<types><type><bitset/></type></types>