Fix flaky test: incompatible qos conditions [13582] #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
changed the title
MiguelCompany
requested changes
Jan 26, 2022
There was a problem hiding this comment.
I think this failing test is related with the changes here.
|
I was checking the failed test and I think it is not related with my changes. The failing function calls directly to the |
MiguelCompany
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the
DDSStatus.IncompatibleQosConditionstest fails due toPubSubReader::incompatible_qos()not taking into accounttotal_count_changes, and instead only increasing the variabletimes_incompatible_qos_by one each time the Waitset returns. This PR correctsPubSubReader::incompatible_qos()so it usestimes_incompatible_qos_.