Skip to content

UpdateServiceDsc: Update localization strings #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

UpdateServiceDsc: Update localization strings #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b1741
UpdateServiceDsc: Update localization strings
johlju Jun 9, 2024
32b2d80
Fix review comment at r1
johlju Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,31 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Updated inital offline package sync WSUS.cab.
- Changed azurepipeline, use latest version of ubuntu and change the management
- Updated initial offline package sync WSUS.cab.
- Changed azure pipeline to use latest version of ubuntu and change the management
of pipeline artifact
- Updated build.ps1 script and build.yaml.
- Changed default timeout in Wait-Win32ProcessStart function for cab installation.
- Updated pester test to support pester v5
- Updated ReadMe.md to removed `RunRuleNow` parameter.
- UpdateServicesApprovalRule
- Updated to load localization strings correctly.
- UpdateServicesCleanup
- Updated to load localization strings correctly.
- UpdateServicesServer
- Updated to load localization strings correctly.

### Added

- Added TestKitchen files for integration tests
- Added requiredmodules Sampler.GitHubTasks, powershell-yaml
- Added required modules, Sampler.GitHubTasks, powershell-yaml
- Added wildcard support in Products parameter of UpdatesServicesServer resource.
(issue #13)

### Fixed

- Fix deploy job in AzurePipeline, Added Sampler.GithubTasks in build.yaml
- Fix issue #61 and #67, with add a foreach loop when `Set-TargetRessource` found
- Fix issue #61 and #67, with add a foreach loop when `Set-TargetResource` found
multiple products dor the same `Title`.
- Fix issue #58 and #66, with removed `-ErrorRecord` parameter on `New-InvalidResultException`
because `$_` not contain an exception.
Expand Down
2 changes: 1 addition & 1 deletion source/DSCResources/MSFT_UpdateServicesApprovalRule/MSFT_UpdateServicesApprovalRule.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
# Load Common Module
$script:resourceHelperModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\DscResource.Common'
Import-Module -Name $script:resourceHelperModulePath
$script:localizedData = Get-LocalizedData -DefaultUICulture 'en-US' -FileName 'MSFT_UpdateServicesApprovalRule.strings.psd1'

$script:localizedData = Get-LocalizedData -DefaultUICulture 'en-US'

<#
.SYNOPSIS
Expand Down
2 changes: 1 addition & 1 deletion source/DSCResources/MSFT_UpdateServicesCleanup/MSFT_UpdateServicesCleanup.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# Load Common Module
$script:resourceHelperModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\DscResource.Common'
Import-Module -Name $script:resourceHelperModulePath -ErrorAction Stop
$script:localizedData = Get-LocalizedData -DefaultUICulture 'en-US' -FileName MSFT_UpdateServicesCleanup.strings.psd1

$script:localizedData = Get-LocalizedData -DefaultUICulture 'en-US'

<#
.SYNOPSIS
Expand Down
3 changes: 2 additions & 1 deletion source/DSCResources/MSFT_UpdateServicesServer/MSFT_UpdateServicesServer.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
# Load Common Module
$script:resourceHelperModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\DscResource.Common'
Import-Module -Name $script:resourceHelperModulePath
$script:localizedData = Get-LocalizedData -DefaultUICulture 'en-US' -FileName 'MSFT_UpdateServicesServer.strings.psd1'

$script:localizedData = Get-LocalizedData -DefaultUICulture 'en-US'

<#
.SYNOPSIS
Expand Down